[issue27645] Supporting native backup facility of SQLite

STINNER Victor added the comment: New changeset 8a9a6b443c57e47e9d10ed7775479aada4dac719 by Victor Stinner in branch '3.7': [3.7] bpo-9566: Fix compiler warnings on Windows (GH-12920) https://github.com/python/cpython/commit/8a9a6b443c57e47e9d10ed7775479aada4dac719 --

[issue27645] Supporting native backup facility of SQLite

Change by STINNER Victor : -- pull_requests: +12848 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27645] Supporting native backup facility of SQLite

STINNER Victor added the comment: New changeset ca405017d5e776a2e3d9291236e62d2e09489dd2 by Victor Stinner in branch 'master': bpo-27645, sqlite: Fix integer overflow on sleep (#6594) https://github.com/python/cpython/commit/ca405017d5e776a2e3d9291236e62d2e09489dd2

[issue27645] Supporting native backup facility of SQLite

Change by STINNER Victor : -- pull_requests: +6292 ___ Python tracker ___ ___

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: Buildbots look happy, closing this one as 'fixed'. Thanks, Aviv! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: New changeset 429ca448d2a36040f229ad9edc67e31fc6d18bf4 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27645: Fix version number in 'database in transaction' fallback (GH-6131)

[issue27645] Supporting native backup facility of SQLite

Change by miss-islington : -- pull_requests: +5895 ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: New changeset bbf7bb7a636b3112ef6f6b31df385606d52517ce by Berker Peksag (Aviv Palivoda) in branch 'master': bpo-27645: Fix version number in 'database in transaction' fallback (GH-6131)

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Thank you Berker, I'm sorry I could not find the time to investigate the problem by myself. -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Aviv Palivoda added the comment: The problem is that change https://www.sqlite.org/src/info/169b5505498c0a7e was part of sqlite version 3.8.8 I opened a PR with a fix. -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Change by Aviv Palivoda : -- pull_requests: +5892 ___ Python tracker ___ ___

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: FYI, I will have some time to debug the test failure this weekend. If I (or Lele or someone else) can't find the problem by Monday, I'm going to revert the patch from 3.7 branch (and probably from master too) --

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Sorry, I could not find an easy enough way to compile against SQLite 3.8.7.1, being on Debian sid myself (3.22). I hope to find some time to try harder. -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: New changeset c546a62c4d7b37ead10f986554a01d6d593227a1 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27645: Skip test_bad_target_in_transaction if SQLite == 3.8.7.1 (GH-6067)

[issue27645] Supporting native backup facility of SQLite

Change by miss-islington : -- pull_requests: +5829 ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: New changeset 7280a4eef5fbe17e8ac82afd71fe6e51843240a5 by Berker Peksag in branch 'master': bpo-27645: Skip test_bad_target_in_transaction if SQLite == 3.8.7.1 (GH-6067)

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: Test also passed on my MBP with SQLite 3.22.0 and the following line rc = _pysqlite_seterror(bck_conn, NULL); returns 1 (SQLITE_ERROR) with "SQL logic error" Looging at

[issue27645] Supporting native backup facility of SQLite

Change by Berker Peksag : -- stage: resolved -> patch review ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Change by Berker Peksag : -- pull_requests: +5828 stage: resolved -> patch review ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: AppVeyor: sqlite3.sqlite_version: 3.21.0 (passed) Travis CI: sqlite3.sqlite_version: 3.8.2 (passed) http://buildbot.python.org/all/#/builders/88/builds/799 sqlite3.sqlite_version: 3.8.2 (passed) --

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: >From test.pythoninfo: sqlite3.sqlite_version: 3.8.7.1 -- ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: >From http://buildbot.python.org/all/#/builders/13/builds/808 == FAIL: test_bad_target_in_transaction (sqlite3.test.backup.BackupTests)

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: Thanks, Lele. Note that Ned gave his permission to get this into 3.7.0b3 at https://github.com/python/cpython/pull/4238#issuecomment-371947334 We can, of course, still revert it before 3.7.0 final. -- resolution: -> fixed

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: New changeset e8a5a92037b1f27809806bb87c17976d2d48d3e9 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27645: Add support for native backup facility of SQLite (GH-4238)

[issue27645] Supporting native backup facility of SQLite

Change by miss-islington : -- pull_requests: +5825 ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: New changeset d7aed4102d2a40c74553240c7f03585624d27aea by Berker Peksag (Emanuele Gaifas) in branch 'master': bpo-27645: Add support for native backup facility of SQLite (GH-4238)

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: I suspect this won't land in 3.7... Let me know if I can do something to make that happen, or instead if I should try to rebase the change on top of current master and rectify references to the Python version. --

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Thank you Serhiy, ok: will simplify the method, hopefully tomorrow. -- ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Serhiy Storchaka added the comment: I prefer to keep Connection.backup() simpler. Additional features can be implemented in pure Python. -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: I need advice on Serhiy's proposal of dropping support to plain file name (see also https://github.com/python/cpython/pull/4238#discussion_r155725986). Wrt the other point I filed issue #32274. --

[issue27645] Supporting native backup facility of SQLite

Serhiy Storchaka added the comment: It seems to me that the code could be much simpler (and more bugfree) if support only a Connection instance as a target. It is easy to create a Connection instance in Python: with sqlite3.connect(filename) as dest:

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Just to keep the door open, I'm willing to to whatever is needed to see this accepted and merged. -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: As suggested by Brett Cannon, I closed the original PR#377 and opened a new one against a rebased version of the implementation. -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Change by Lele Gaifax : -- pull_requests: +4203 ___ Python tracker ___ ___

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Reasonable and quite simple to implement: done in commit https://github.com/lelit/cpython/commit/960303f9eb394e2ba91d10e5e674997a48811ac2 -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Cédric Krier added the comment: I'm using sqlitebck which provides similar functionality but instead of using a file name to store the backup it uses connection instances. I find it very useful. Here is my use case: to run tests of an application that requires a

[issue27645] Supporting native backup facility of SQLite

R. David Murray added the comment: If you are talking about Gerhard, if he was still around you'd probably get a similar response, but he hasn't been around much. So this is somewhat of an orphaned module currently and it takes longer for an issue to get traction.

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: I rebased my v2 set of changesets into a new branch: https://github.com/lelit/cpython/tree/sqlite-backup-api-v3 I really don't know if anybody is interested beyond me, I did everything has been suggested/requested, and honestly I feel a

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Monthly offer to do whatever is needed to easy the path to adoption :-) -- ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

R. David Murray added the comment: There's a good chance, yes. You'll have to keep periodically pinging the issue (say once a month :), and if you can specifically talk someone into doing a review your chances go up :) For it to go in we need a review from a core-dev, but one or more

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Is there any chance this could be accepted for Python 3.7? -- ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Changes by Anish Shah : -- nosy: +anish.shah ___ Python tracker ___ ___

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Thank you Aviv, I applied your suggestions and opened a PR. -- ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Changes by Roundup Robot : -- pull_requests: +315 ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Aviv Palivoda added the comment: I actually looked at the patch and have a few comments: 1. You need to put Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS before the sqlite3 calls (especially the sleep). 2. I think that the `pysqlite_connection_backup` function will look a lot better if you

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Now that we are is officially on GH, would you welcome a PR rebasing this patch on top of the master branch? -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Changes by Cédric Krier : -- nosy: +ced ___ Python tracker ___ ___ Python-bugs-list

[issue27645] Supporting native backup facility of SQLite

Changes by Ned Deily : -- nosy: +ghaering ___ Python tracker ___ ___ Python-bugs-list

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: I guess the chance of getting this merged before the 3.6 betas is very low, but if there is *anything* I could do to raise it, please tell :-) -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Ok, the agreement is fullfilled. -- ___ Python tracker ___ ___

[issue27645] Supporting native backup facility of SQLite

R. David Murray added the comment: If you have a copy of your original agreement you could fax it to the PSF, but it is probably easier to just to sign the electronic one. -- nosy: +r.david.murray ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: WRT to the agreement form, I guess I'll have to compile it even if I already contributed to Python decades ago (ObjC, readline, NeXT support...), right? Will try to do whatever is needed in the next days... -- ___

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: For the documentation see https://github.com/lelit/cpython/commit/bd82f8de9800ae40b33ddf1e4b7d72f10bc9c10e or the attached patch. -- Added file: http://bugs.python.org/file43930/issue27645-doc.patch ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Berker Peksag added the comment: Thanks for the patch! I haven't had a chance to review the patch yet, but we also need documentation updates to Doc/library/sqlite3.rst. -- nosy: +berker.peksag stage: -> patch review ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

Changes by Lele Gaifax : -- keywords: +patch Added file: http://bugs.python.org/file43928/issue27645.patch ___ Python tracker ___

[issue27645] Supporting native backup facility of SQLite

Emanuel Barry added the comment: That's really nice, thank you for doing this! To get your code reviewed, though, you should upload a patch here. With git, you can do 'git diff > my_patch_file_name.patch' in your local repo, then you can upload the resulting file here. If you haven't done so

[issue27645] Supporting native backup facility of SQLite

Lele Gaifax added the comment: Here is a preliminary implementation: https://github.com/lelit/cpython/commit/b7456eb6a55568639a41efb5d88ab4d9b3c20337 -- ___ Python tracker

[issue27645] Supporting native backup facility of SQLite

New submission from Lele Gaifax: It would be nice if the sqlite3 stdlib module could expose the SQLite Online Backup API. I'm willing to implement it, as encouraged by Paul Moore. See also: https://mail.python.org/pipermail/python-dev/2016-July/145570.html -- components: Extension