[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Change by Christian Heimes : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: By the way problem with AES-GCM is tracked in https://bugs.python.org/issue29324 . It was caused in a Kernel API change. Jan has provided a fix. I need to find some spare time to dig into Kernel sources and verify the patch. --

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: I'll look into the matter and push a fix after the migration to github today. -- ___ Python tracker ___

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

STINNER Victor added the comment: What is the status of this issue? test_aead_aes_gcm() fails on my Fedora 25 (Python: default branch). haypo@selma$ cat /etc/fedora-release Fedora release 25 (Twenty Five) haypo@selma$ uname -r 4.9.5-200.fc25.x86_64 test test_socket failed -- Traceback (most

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Changes by Christian H : -- nosy: +Christian H ___ Python tracker ___ ___

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Roundup Robot added the comment: New changeset a951f8f30922 by Victor Stinner in branch 'default': Cleanup socketmodule.c https://hg.python.org/cpython/rev/a951f8f30922 New changeset 3a6917c73857 by Victor Stinner in branch 'default': socket: Fix memory leak in sendmsg() and sendmsg_afalg()

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Roundup Robot added the comment: New changeset 55d77f5a7cb3 by Christian Heimes in branch 'default': Issue 27744: test_aes_cbc is blocking x86-64 Ubuntu 15.10 Skylake CPU 3.x for a while. Require Kernel 4.3+ for now https://hg.python.org/cpython/rev/55d77f5a7cb3 --

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: x86-64 Ubuntu 15.10 Skylake CPU 3.x is still blocking. It looks like I have to add another workaround for a Ubuntu quirk. -- ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Xiang Zhang added the comment: My PC is Ubuntu15.10, kernel 4.2, though CPU not Skylake. Everything works fine. test_aead_aes_gcm (test.test_socket.LinuxKernelCryptoAPI) ... skipped "('[Errno 2] No such file or directory', 'aead', 'gcm(aes)')" test_aes_cbc

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: Some distributions mess with the Kernel or disable user-space crypto. I have added some tweaks and fixed a couple of buildbots. I don't know what is going on with x86-64 Ubuntu 15.10 Skylake CPU. It's a Kernel 4.2 machine and should support AES-CBC.

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Roundup Robot added the comment: New changeset e3b83bfa02c5 by Christian Heimes in branch 'default': Issue 27744: skip test if AF_ALG socket bind fails https://hg.python.org/cpython/rev/e3b83bfa02c5 -- ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

STINNER Victor added the comment: > Also, the Gentoo buildbots fail: > http://buildbot.python.org/all/builders/x86%20Gentoo%20Non-Debug%20with%20X%203.x/builds/1368/steps/test/logs/stdio > == > ERROR: test_aead_aes_gcm

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Martin Panter added the comment: Also, the Gentoo buildbots fail: http://buildbot.python.org/all/builders/x86%20Gentoo%20Non-Debug%20with%20X%203.x/builds/1368/steps/test/logs/stdio == ERROR: test_aead_aes_gcm

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Martin Panter added the comment: Despite the last changes, test_aes_cbc() hangs for fifteen minutes: http://buildbot.python.org/all/builders/x86-64%20Ubuntu%2015.10%20Skylake%20CPU%203.x/builds/1298/steps/test/logs/stdio running: test_socket (900 sec) 0:28:47 [332/402] test_socket crashed

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Roundup Robot added the comment: New changeset 4ebe3ade6922 by Christian Heimes in branch 'default': Issue 27744: AES-CBC and DRBG need Kernel 3.19+ https://hg.python.org/cpython/rev/4ebe3ade6922 -- ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Roundup Robot added the comment: New changeset ee32af890e27 by Christian Heimes in branch 'default': Issue 27744: Check for AF_ALG support in Kernel https://hg.python.org/cpython/rev/ee32af890e27 -- ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Roundup Robot added the comment: New changeset 52404f9596b5 by Christian Heimes in branch 'default': Issue #27744: correct comment and markup https://hg.python.org/cpython/rev/52404f9596b5 -- ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Roundup Robot added the comment: New changeset 74ce062a0397 by Christian Heimes in branch 'default': Issue #27744: Add AF_ALG (Linux Kernel crypto) to socket module. https://hg.python.org/cpython/rev/74ce062a0397 -- nosy: +python-dev ___ Python

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: I have removed binascii.(un)hexlify(). -- Added file: http://bugs.python.org/file44359/AF_ALG-kernel-crypto-support-for-socket-module-5.patch ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Changes by Christian Heimes : Added file: http://bugs.python.org/file44295/AF_ALG-kernel-crypto-support-for-socket-module-4.patch ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Changes by Christian Heimes : Added file: https://bugs.python.org/file44268/AF_ALG-kernel-crypto-support-for-socket-module-3.patch ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: New patch with setsockopt(socket.SOL_ALG, socket.ALG_SET_AEAD_AUTHSIZE, None, taglen) instead of (None, taglen). -- Added file: https://bugs.python.org/file44248/AF_ALG-kernel-crypto-support-for-socket-module-2.patch

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: Thanks for your review, Victor. I have addressed most of your remarks. * algset() is now called sendmsg_afalg(). It behaves more like a specialized version of sendmsg() and can optionally handle an array of iovec. * I had to add another variant of

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

STINNER Victor added the comment: I reviewed AF_ALG-kernel-crypto-support-for-socket-module.patch. -- nosy: +haypo ___ Python tracker ___

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Christian Heimes added the comment: Working patch with tests and documentation. socket.algset() isn't strictly necessary but makes the feature much more pleasant to use. I accept ideas for a better name, though. -- keywords: +patch Added file:

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Changes by Christian Heimes : Removed file: http://bugs.python.org/file44088/Microsoft_Screen_Sharing_for_Lumia_Phones_HD-10_UG_th_TH.pdf ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Changes by Pan Naekton : Added file: http://bugs.python.org/file44088/Microsoft_Screen_Sharing_for_Lumia_Phones_HD-10_UG_th_TH.pdf ___ Python tracker

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

Changes by Cory Benfield : -- nosy: +Lukasa ___ Python tracker ___ ___ Python-bugs-list

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

New submission from Christian Heimes: Linux has a netlink-based user-space interface for Kernel cryptography. Kernel based crypto has a couple of advantages that are explained at http://www.chronox.de/libkcapi/html/ch01s02.html . The document doesn't mention that a crypto socket also supports