[issue27911] Unnecessary error checks in exec_builtin_or_dynamic

Brett Cannon added the comment: Thanks for the patch! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue27911] Unnecessary error checks in exec_builtin_or_dynamic

Roundup Robot added the comment: New changeset 96c6816825dc by Brett Cannon in branch 'default': Issue #27911: Remove some unnecessary error checks in import.c. https://hg.python.org/cpython/rev/96c6816825dc -- nosy: +python-dev ___ Python tracker

[issue27911] Unnecessary error checks in exec_builtin_or_dynamic

Brett Cannon added the comment: Patch LGTM. Thanks for catching that, Xiang! I'll commit your fix when I can (might not be until after 3.6b1 since feature improvements are taking priority on my time to make the feature freeze deadline). -- assignee: -> brett.cannon

[issue27911] Unnecessary error checks in exec_builtin_or_dynamic

Xiang Zhang added the comment: It's okay. Glad that you spare some time to reply. :) -- ___ Python tracker ___

[issue27911] Unnecessary error checks in exec_builtin_or_dynamic

New submission from Xiang Zhang: The two PyErr_Occurred check in exec_builtin_or_dynamic are unnecessary. The PyModule_Check at the beginning of exec_builtin_or_dynamic has eliminated the possibility for PyModule_GetDef/State to fail. -- components: Interpreter Core files: