[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Changes by Serhiy Storchaka : -- type: security -> crash ___ Python tracker ___

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Roundup Robot added the comment: New changeset 637ce96423ef by Serhiy Storchaka in branch '2.7': Issue #27963: Fixed possible null pointer dereference in ctypes.set_conversion_mode(). https://hg.python.org/cpython/rev/637ce96423ef -- nosy: +python-dev

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Changes by Xiang Zhang : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Minh Râu added the comment: the patch look good. Thank Xiang -- ___ Python tracker ___ ___ Python-bugs-list

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Xiang Zhang added the comment: issue27963.patch tries to fix the crash caused by not enough memory and avoid inconsistent state when failure. -- keywords: +patch Added file: http://bugs.python.org/file44390/issue27963.patch ___ Python tracker

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Xiang Zhang added the comment: Ooh, I treat dereference as decref, sorry. Then I think it may happen when there is not enough memory. But your patch is not complete, at least you should Py_DECREF(result). But this function may need more care since the malloc failure in it will alter states.

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Xiang Zhang added the comment: Hmm, I tested the example snippet but it works. And PyMem_Free shouldn't fail when encounter NULL. The doc explicitly says "If p is NULL, no operation is performed". -- nosy: +xiang.zhang ___ Python tracker

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Changes by Minh Râu : -- title: null poiter dereference in set_conversion_mode dua uncheck _ctypes_conversion_errors -> null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors ___ Python