Berker Peksag added the comment:
Great, closing this then.
> And the next release will include this patch?
Christian (one of our SSL module maintainers) just reviewed the patch so the
next step is to address his review comments and upload a new patch. If you
don't see any movement from
SenBin Yu added the comment:
Yes, the giving code is what i desiere and shoud be supported. Sorry, i haven't
see the patch file.And the next release will include this patch?
--
___
Python tracker
Berker Peksag added the comment:
Did you look at the patch? It adds the following test case:
+s = socket.socket()
+sfd = s.fileno()
+# Create secure socket from fileno
+ss = ssl.SSLSocket(fileno=sfd)
+self.assertTrue(ss.fileno() == sfd)
Isn't that what
SenBin Yu added the comment:
The issue 27629 describe creating a SSLSocket only with server_hostname
argument.But what i said is that we can't creating a SSLSocket with fileno
argument from a existing socket.I'm strange about this code design that
meaningless branch conditions exists.
Berker Peksag added the comment:
Thanks for the report. This looks like a duplicate of issue 27629. Please
provide a reproducer if it's different problem than issue 27629.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: ->
New submission from SenBin Yu:
In the SSLSocket __init__ function, it's ok to do a socket type check with
argument sock.But meanwhile the sock argument can't be None, which make the
SSLSocket socket __init__ way meaningless.Although there are three branch
conditions as argument sock, fileno