[issue28190] Detect curses headers correctly for cross-compiling

Chi Hsuan Yen added the comment: > The only change that is needed here is to not include /usr/include/ncursesw > in setup.py when cross compiling No. Lots of codes in _cursesmodule.c need to know whether it's ncursesw, ncurses, or SysV's curses. For example: (segments below are from unpatched

[issue28190] Detect curses headers correctly for cross-compiling

Xavier de Gaye added the comment: The only change that is needed here is to not include /usr/include/ncursesw in setup.py when cross compiling to ensure that the headers of the build platform are not included. When cross compiling Python, it is the responsability of the packager to set the

[issue28190] Detect curses headers correctly for cross-compiling

Chi Hsuan Yen added the comment: > second issue is that you apparently don't do the changes for term.h term.h is included only if ncurses is missing and the system (SysV) curses is used, so I didn't change it. See below: #ifdef __sgi #include #endif #ifdef HAVE_NCURSES_H #include #else

[issue28190] Detect curses headers correctly for cross-compiling

Matthias Klose added the comment: the upstream ncurses has the ncursesw subdirinclude name, so you apparently can assume that this directory name is fixed *iff* it exists, however the ncursesw installation can be found in /include instead. Can your changes cope with that? second issue is

[issue28190] Detect curses headers correctly for cross-compiling

Chi Hsuan Yen added the comment: A clean patch without changes in ./configure. autoreconf necessary -- Added file: http://bugs.python.org/file45790/ncurses-headers.patch ___ Python tracker

[issue28190] Detect curses headers correctly for cross-compiling

Masayuki Yamamoto added the comment: test_curses has been skipped almost. the skip reason has been written "cygwin's curses mostly just hangs" in test case class. I removed the skip condition, and ran test. Tests was almost passed. The only, unget_wch was failed by edge case '\U0010',

[issue28190] Detect curses headers correctly for cross-compiling

Chi Hsuan Yen added the comment: Hmm it's surprising for me that an irrelevant patch fixes issues on Cygwin. Does test_curses pass? -- ___ Python tracker

[issue28190] Detect curses headers correctly for cross-compiling

Masayuki Yamamoto added the comment: Now, Cygwin platform is able to build core interpreter on default branch. But the curses module has been failed to build. Therefore I tried to build curses module on Cygwin (Vista x86) using this patch. And it has been succeeded. The patch effect at build

[issue28190] Detect curses headers correctly for cross-compiling

Changes by Xavier de Gaye : -- nosy: +xdegaye ___ Python tracker ___ ___ Python-bugs-list

[issue28190] Detect curses headers correctly for cross-compiling

Matthias Klose added the comment: looks good to me, thanks for working on this. -- ___ Python tracker ___ ___

[issue28190] Detect curses headers correctly for cross-compiling

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue28190] Detect curses headers correctly for cross-compiling

Changes by Chi Hsuan Yen : -- title: Cross-build _curses failed if host ncurses headers and target ncurses headers have different layouts -> Detect curses headers correctly for cross-compiling ___ Python tracker