[issue2824] zipfile to handle duplicate files in archive

Change by Irit Katriel : -- versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.6, Python 2.7, Python 3.2 ___ Python tracker ___

[issue2824] zipfile to handle duplicate files in archive

Change by Felix C. Stegerman : -- nosy: +obfusk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2824] zipfile to handle duplicate files in archive

Jerry Heiselman added the comment: Further, some tools like zipgrep, seem to iterate over the toc in the zipfile and end up running the grep part once per entry leading to some duplication of data returned without it being obvious that there wasn't actually duplicate data in the zip

[issue2824] zipfile to handle duplicate files in archive

Jerry Heiselman added the comment: This just bit us too. I don't feel like a warning is enough. In our case, we want to prevent it from happening to begin with so that a developer who isn't expecting this doesn't have to know ahead of time to check for a file. Once a duplicate is in the zip

[issue2824] zipfile to handle duplicate files in archive

Irit Katriel added the comment: This was changed to a warning in issue20262. Is that enough or should it be an exception? -- nosy: +iritkatriel ___ Python tracker ___

[issue2824] zipfile to handle duplicate files in archive

Changes by Wessel Badenhorst wess...@gmail.com: -- type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2824 ___ ___

[issue2824] zipfile to handle duplicate files in archive

Michael Driscoll added the comment: Whatever became of this? We just stumbled across this bug in our code at work where we accidentally put multiple files of the same name into the zip file and not only does it not overwrite the others, but when you go to access that file name, it grabs the

[issue2824] zipfile to handle duplicate files in archive

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2824 ___ ___ Python-bugs-list

[issue2824] zipfile to handle duplicate files in archive

Yaniv Aknin yaniv.ak...@gmail.com added the comment: Attached is the addition of the 'low_level' parameter to ZipFile. Included are the parameter, a global switch controlling whether the parameter will raise an Exception or trigger a DeprecationWarning (the latter, for now), updated tests and

[issue2824] zipfile to handle duplicate files in archive

anatoly techtonik techto...@gmail.com added the comment: On the second thought having a switch for a low-level zip format hacking is a good addition. It may also be used for in-place removals from .zip file by erasing directory entry. Otherwise remove operation will require repacking archive

[issue2824] zipfile to handle duplicate files in archive

Yaniv Aknin yaniv.ak...@gmail.com added the comment: This affect 3.x as well. Regardless of the exact version this will come out in, I think the only proper solution is one with which we eventually, maybe in two versions' time, end up with a behaviour that raises an exception upon double

[issue2824] zipfile to handle duplicate files in archive

anatoly techtonik techto...@gmail.com added the comment: Still an issue for Python 2.7 -- versions: +Python 2.7 Added file: http://bugs.python.org/file16776/test2824.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2824

[issue2824] zipfile to handle duplicate files in archive

Alexandru V. Mosoi brtz...@gmail.com added the comment: a similar problem appears when the zip file contains two files as in: ['_test/tree.pl', '_test/']. for ZipFile.extractall() when _test/tree.pl is extracted _test/ is created and the the extraction of _test/ fails because OSError: [Errno

[issue2824] zipfile to handle duplicate files in archive

Martin McNickle [EMAIL PROTECTED] added the comment: The mechanism for throwing an error has been written, however for the case of a duplicated filename, it appears to have been deliberatly not been used by the original author.: def _writecheck(self, zinfo): Check for errors before

[issue2824] zipfile to handle duplicate files in archive

anatoly techtonik [EMAIL PROTECTED] added the comment: How about adding optional replace=True attribute to the write method? So that people who are not aware enough to adjust the code and handle new warning could still get valid archives. __ Tracker [EMAIL

[issue2824] zipfile to handle duplicate files in archive

New submission from anatoly techtonik [EMAIL PROTECTED]: ZipFile allows to add the same file to archive twice. I bet it is not intended behavior for many users who would like to either replace file inside of archive or get runtime warning about duplicate file to be added.

[issue2824] zipfile to handle duplicate files in archive

Georg Brandl [EMAIL PROTECTED] added the comment: I think a warning would be sensible here. The behavior is certainly not what I would expect. -- nosy: +alanmcintyre, georg.brandl __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2824