[issue28393] Update encoding lookup docs wrt #27938

Change by Ville Skyttä : -- pull_requests: +6085 ___ Python tracker ___ ___

[issue28393] Update encoding lookup docs wrt #27938

STINNER Victor added the comment: Thank you Ville Skyttä for your contribution! I merged your PR and backported it to Python 3.6. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue28393] Update encoding lookup docs wrt #27938

STINNER Victor added the comment: New changeset 77bf6da7258b4a312e224860ea50ac010aa17c1e by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-28393: Update encoding lookup docs wrt bpo-27938 (GH-4871) (#4881)

[issue28393] Update encoding lookup docs wrt #27938

Change by Roundup Robot : -- pull_requests: +4776 ___ Python tracker ___

[issue28393] Update encoding lookup docs wrt #27938

STINNER Victor added the comment: New changeset 297fd876aad8ef443d8992618de22c46dbda258b by Victor Stinner (Ville Skyttä) in branch 'master': bpo-28393: Update encoding lookup docs wrt bpo-27938 (#4871)

[issue28393] Update encoding lookup docs wrt #27938

Ville Skyttä added the comment: I'm getting a 500 internatl server error trying to update https://bugs.python.org/review/28393/, so noting here that the latest review issue has been addressed in https://github.com/python/cpython/pull/4871 --

[issue28393] Update encoding lookup docs wrt #27938

Change by Ville Skyttä : -- pull_requests: +4762 ___ Python tracker ___ ___

[issue28393] Update encoding lookup docs wrt #27938

Marc-Andre Lemburg added the comment: Thanks, Ville. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue28393] Update encoding lookup docs wrt #27938

Ville Skyttä added the comment: codecs-doc-3 contains a versionadded note about us-ascii. I think that's the only end user visible change in the new implementation. -- Added file: http://bugs.python.org/file45085/codecs-doc-3.patch ___ Python

[issue28393] Update encoding lookup docs wrt #27938

Marc-Andre Lemburg added the comment: The names are indeed case-insensitive. However, something important is missing: the implementation details changed between Python 3.5 and 3.6. Please check the implementation for details and update the documentation with versionadded flags. Thanks.

[issue28393] Update encoding lookup docs wrt #27938

Ville Skyttä added the comment: I believe (but haven't checked) that additionally, encoding names are case insensitive with respect to the fast-path behavior. But then again I also suppose that's the way it was before #27938 as well, which is why I didn't change that in this patch. But why

[issue28393] Update encoding lookup docs wrt #27938

Berker Peksag added the comment: Thanks for the patch! Do we still need to keep the last sentence? Is there any other alternatives that can be used? Perhaps the word "spellings" can be changed with "aliases" to make the sentence a little bit clearer. -- nosy: +berker.peksag stage: ->

[issue28393] Update encoding lookup docs wrt #27938

New submission from Ville Skyttä: The attached patch brings codecs docs up to date with respect to changes in #27938. -- assignee: docs@python components: Documentation files: codecs-doc.patch keywords: patch messages: 278354 nosy: docs@python, haypo, scop priority: normal severity: