[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Brett Cannon added the comment: Thanks for the PR! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Change by Brett Cannon : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

miss-islington added the comment: New changeset 338d54f0a59dc5e5b6c9e7397340169f3a3f8ea4 by Miss Islington (bot) (Stefano Rivera) in branch 'master': bpo-28401: prevent Py_DEBUG builds from trying to import limited ABI modules (GH-1766)

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Stefano Rivera added the comment: > whether this would confuse users since they will simply get an ImportError > instead of some other error and thus will they be able to realize why there's > a problem? It's the same behaviour we have for any other module on the import path, that doesn't

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Brett Cannon added the comment: So limited ABI modules can't be imported by a Py_DEBUG build. Stefano's patch just skips over them. That seems reasonable, but one question I do have is whether this would confuse users since they will simply get an ImportError instead of some other error and

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Changes by Roundup Robot : -- pull_requests: +1847 ___ Python tracker ___

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Dmitry Shachnev added the comment: [Matthias Klose (doko) 2016-10-27 15:45] > I'm not sure that you really want this, because it would make it impossible > to build an extension for the stable ABI for a debug build. It looks like that is already impossible:

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Changes by Dmitry Shachnev : -- nosy: +mitya57 ___ Python tracker ___ ___ Python-bugs-list

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Stefano Rivera added the comment: I wouldn't say it's *entirely* Debian-specific. It just bites anyone who actually needs these tags to differentiate between built extensions. (Mostly Debian) Yes, changing the tag is a more complete solution. It just seemed that that option was decided

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

Matthias Klose added the comment: I'm not sure that you really want this, because it would make it impossible to build an extension for the stable ABI for a debug build. The problem is Debian specific, because we install the extension modules for normal and debug builds in the same location.

[issue28401] Don't support the PEP384 stable ABI in pydebug builds

New submission from Stefano Rivera: setup.py build for a library using py_limited_api will always generate a stable ABI tagged shared library, even under the pydebug interpreter. This means that extensions that are built for a pydebug interpreter may be accidentally (and brokenly) imported in