[issue28468] Add platform.freedesktop_os_release()

2020-12-23 Thread miss-islington
miss-islington added the comment: New changeset bfda4f5776fd20f92b441c8a88ee7a9d44dc8777 by Victor Stinner in branch 'master': bpo-28468: Fix typo in _os_release_candidates (GH-23913) https://github.com/python/cpython/commit/bfda4f5776fd20f92b441c8a88ee7a9d44dc8777 -- nosy:

[issue28468] Add platform.freedesktop_os_release()

2020-12-23 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +22763 pull_request: https://github.com/python/cpython/pull/23913 ___ Python tracker ___

[issue28468] Add platform.freedesktop_os_release()

2020-11-30 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28468] Add platform.freedesktop_os_release()

2020-11-30 Thread STINNER Victor
STINNER Victor added the comment: I merged Christian's PR 23492. The initial issue, add a function to parse the os-release file, is now solved, so I close the issue. If you want to use it in a test, please open a new issue. Thanks everyone for this constructive discussion, IMO the final

[issue28468] Add platform.freedesktop_os_release()

2020-11-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset 5c73afc36ee6cca41009a510092e1f901c5dc0a0 by Christian Heimes in branch 'master': bpo-28468: Add platform.freedesktop_os_release() (GH-23492) https://github.com/python/cpython/commit/5c73afc36ee6cca41009a510092e1f901c5dc0a0 --

[issue28468] Add platform.freedesktop_os_release()

2020-11-30 Thread STINNER Victor
STINNER Victor added the comment: > In this case, please also provide a way to provide the value of the > VERSION_ID field. I'm not sure what you mean. PR 23492 exposes the whole content of the os-release file as a dict. There is no special case for any field. VERSION_ID can be retrieved

[issue28468] Add platform.freedesktop_os_release()

2020-11-30 Thread STINNER Victor
STINNER Victor added the comment: Matthias Klose: > It doesn't make sense to blacklist whole distributions in tests. Adding freedesktop_os_release() and using it are two different topics. I understand the the SC decision is on adding the function. Using it to skip tests should be decided on

[issue28468] Add platform.freedesktop_os_release()

2020-11-30 Thread Matthias Klose
Matthias Klose added the comment: I don't agree with this decision, but ok. In this case, please also provide a way to provide the value of the VERSION_ID field. It doesn't make sense to blacklist whole distributions in tests. -- ___ Python

[issue28468] Add platform.freedesktop_os_release()

2020-11-30 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: This issue was brought to the Python Steering Council, and we deliberated it at today's SC meeting. With a vote of 4 approvals and one abstention, we have approved the addition of this API. -- nosy: +barry ___

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Christian Heimes
Christian Heimes added the comment: We have reached an impasse. Therefore I have contacted the steering council and requested mediation. Victor will abstain from the decision process. -- ___ Python tracker

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: Don't get me wrong. I don't want to put my vote in this hot discussion but mention my use case. test.support can solve my need. On another hand, very many Python batteries exist to solve third-party needs and are not required by CPython itself. So I'm +0

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Matthias Klose
Matthias Klose added the comment: > I just needed such functionality for PTY tests another use case for a test. so please add it to the test framework, also suggested by Marc. -- ___ Python tracker

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Andrew Svetlov
Andrew Svetlov added the comment: I just needed such functionality for PTY tests: https://github.com/python/cpython/pull/23514 -- nosy: +asvetlov ___ Python tracker ___

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Christian Heimes
Christian Heimes added the comment: Pablo, I would like to get mediation from the release manager. I want to add an interface to the os-release file. It's a decade-old standard from freedesktop.org. The file is available in the minimal base installation of virtually every Linux

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 25.11.2020 11:45, Christian Heimes wrote: > > Christian Heimes added the comment: > > PS: MAL, would it be possible to suppress your email footer? BPO is not an > advertisement channel. That's an ancient bug on bpo, which apparently still haven't

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Christian Heimes
Christian Heimes added the comment: PS: MAL, would it be possible to suppress your email footer? BPO is not an advertisement channel. -- ___ Python tracker ___

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Christian Heimes
Christian Heimes added the comment: > It's not pointless. The rate of change in the field is why this > particular API did not work out in practice. It was working fine > at the time I added it, but then quickly became unmaintainable. Yes, it's pointless. You are arguing that os-release is

Re: [issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread M.-A. Lemburg
On 25.11.2020 11:13, STINNER Victor wrote: > Platform was always a thin wrapper to OS functions. For example, there is no > unified API to retrieve OS name and version on Windows, macOS or Linux. You > need to pick the proper function. For me, freedesktop_os_release() just > follows this trend.

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread STINNER Victor
Change by STINNER Victor : -- title: Add platform.freedesktop_osrelease() -> Add platform.freedesktop_os_release() ___ Python tracker ___

[issue28468] Add platform.freedesktop_os_release()

2020-11-25 Thread Christian Heimes
Change by Christian Heimes : -- title: Add platform.freedesktop_osrelease() -> Add platform.freedesktop_os_release() ___ Python tracker ___