[issue28533] Replace asyncore/asynchat/smptd in tests

STINNER Victor added the comment: I wrote PR 29521 to remove the asyncore, asynchat and smtpd modules. > libregrtest/save_env.py only checks that asyncore.socket_map is not modified, > we can keep it until asyncore is really removed. I chose to remove it instead of my PR. > test_support.py

[issue28533] Replace asyncore/asynchat/smptd in tests

STINNER Victor added the comment: I forgot about this issue and I created a duplicate: bpo-45785. Copy of my messages. I propose to remove asyncore, asynchat and smtpd modules from the Python standard library to remove the Python maintenance burden. These modules are deprecated since

[issue28533] Replace asyncore/asynchat/smptd in tests

Change by STINNER Victor : -- keywords: +patch pull_requests: +27771 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/29521 ___ Python tracker

[issue28533] Replace asyncore/asynchat/smptd in tests

Change by Irit Katriel : -- assignee: aeros -> components: +Tests nosy: +asvetlov title: Replace asyncore -> Replace asyncore/asynchat/smptd in tests versions: +Python 3.11 -Python 3.7 ___ Python tracker

[issue28533] Replace asyncore

Irit Katriel added the comment: asyncore, asynchat and smtpd are all deprecated now, for removal in 3.12. While the tests are not blocking their removal (we can move them to test.support) it would still be better to rewrite these tests. -- ___

[issue28533] Replace asyncore

Change by Irit Katriel : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28533] Replace asyncore

STINNER Victor added the comment: So the first step is to decide if it's ok to remove smtpd right now. -- ___ Python tracker ___

[issue28533] Replace asyncore

Irit Katriel added the comment: There is actually one usage outside of the tests: Lib/smtpd.py There is a note in the doc saying " The aiosmtpd package is a recommended replacement for this module. It is based on asyncio and provides a more straightforward API. smtpd should be considered

[issue28533] Replace asyncore

STINNER Victor added the comment: Irit: > If the tests are the only thing blocking removal, does it make sense to move > asyncore and asynchat to test.support and get on with removing them from the > stdlib? Yes, it makes sense and it can be done right now, since asynchat/asyncore is

[issue28533] Replace asyncore

Irit Katriel added the comment: If the tests are the only thing blocking removal, does it make sense to move asyncore and asynchat to test.support and get on with removing them from the stdlib? -- nosy: +iritkatriel ___ Python tracker

[issue28533] Replace asyncore

Kyle Stanley added the comment: Since this issue is now a significant blocker for PEP 594 (remove stdlib dead batteries, which includes asyncore and asynchat), I'm going to prioritize working on this and assign it to myself. -- assignee: -> aeros

[issue28533] Replace asyncore

Jackson Riley added the comment: Lib/test/test_pyclbr.py - subissue issue38866 A trivial one! -- nosy: +jacksonriley ___ Python tracker ___

[issue28533] Replace asyncore

Kyle Stanley added the comment: > I'm happy to work on replacing asyncore usage in one of the other test files. Sounds good, just let us know which one(s) you're working on. (: -- ___ Python tracker

[issue28533] Replace asyncore

Joannah Nanjekye added the comment: @dankreso, the issue is still open and no one has claimed it yet. So feel free to open a pull request. -- ___ Python tracker ___

[issue28533] Replace asyncore

dankreso added the comment: Hi, is this still open? I'm happy to work on replacing asyncore usage in one of the other test files. -- nosy: +dankreso ___ Python tracker ___

[issue28533] Replace asyncore

Change by Kyle Stanley : -- nosy: +aeros ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28533] Replace asyncore

Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28533] Replace asyncore

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___

[issue28533] Replace asyncore

Changes by Mariatta Wijaya : -- dependencies: +test_poplib replace asyncore ___ Python tracker ___

[issue28533] Replace asyncore

Grzegorz Grzywacz added the comment: ./Lib/test/test_poplib.py sub-issue issue30514 Fixed issue number from previous comment -- ___ Python tracker ___

[issue28533] Replace asyncore

Grzegorz Grzywacz added the comment: ./Lib/test/test_poplib.py sub-issue issue28533 -- ___ Python tracker ___

[issue28533] Replace asyncore

Changes by Mariatta Wijaya : -- stage: -> needs patch versions: +Python 3.7 ___ Python tracker ___

[issue28533] Replace asyncore

STINNER Victor added the comment: > I think it's a good idea to split this task into few parts/PR. Let me start > from ./Lib/test/test_poplib.py. Once you have a patch, open a new issue and mention it here. -- ___ Python tracker

[issue28533] Replace asyncore

Grzegorz Grzywacz added the comment: I would like to work on this issue. I think it's a good idea to split this task into few parts/PR. Let me start from ./Lib/test/test_poplib.py. What about rewriting pop3 server stub using asyncio, i think requests could be handled synchronously, there

[issue28533] Replace asyncore

STINNER Victor added the comment: asyncore was modified to emit a DeprecationWarning: http://bugs.python.org/issue25002#msg279417 But then a lot of code starts with to fail -Werror. Copy of Martin Panter's msg279469: I normally run the tests with -Werror, and the failures I get are: *

[issue28533] Replace asyncore

STINNER Victor added the comment: > asyncore is still used in several tests and should be replaced. Here is the list of Python files using asyncore: haypo@selma$ grep -l asyncore $(find -name "*.py") ./Lib/asyncore.py ./Lib/asynchat.py ./Lib/test/test_smtpd.py ./Lib/test/test_asyncore.py

[issue28533] Replace asyncore

Changes by Mariatta Wijaya : -- components: +asyncio nosy: +gvanrossum, yselivanov ___ Python tracker ___

[issue28533] Replace asyncore

New submission from Mariatta Wijaya: Deprecation warning was added to asyncore in https://bugs.python.org/issue25002 asyncore is still used in several tests and should be replaced. -- messages: 279439 nosy: Mariatta priority: normal severity: normal status: open title: Replace asyncore