[issue28838] Using consistent naming for arguments of "call" functions (C API)

STINNER Victor added the comment: Serhiy Storchaka added the comment: > Since no one on Python-Dev has objections, I'm fine with this too. I was > opposed not so much to the changes themselves, as to making large changes to > one of basic files that could affect everybody without wider

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Serhiy Storchaka added the comment: Since no one on Python-Dev has objections, I'm fine with this too. I was opposed not so much to the changes themselves, as to making large changes to one of basic files that could affect everybody without wider discussion. Excuse me if I looked unfriendly.

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Roundup Robot added the comment: New changeset 3ab0a6692e25 by Victor Stinner in branch 'default': abstract.h: remove long outdated comment https://hg.python.org/cpython/rev/3ab0a6692e25 -- ___ Python tracker

[issue28838] Using consistent naming for arguments of "call" functions (C API)

STINNER Victor added the comment: I consider that the cleanup itself is done, so I close the issue. For further enhancements, I will open new issues. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Serhiy Storchaka added the comment: Thanks Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue28838] Using consistent naming for arguments of "call" functions (C API)

STINNER Victor added the comment: Serhiy: "Victor, it would be worth to discuss this change on Python-Dev." Done: https://mail.python.org/pipermail/python-dev/2016-December/146999.html -- ___ Python tracker

[issue28838] Using consistent naming for arguments of "call" functions (C API)

STINNER Victor added the comment: I pushed cleanup-2.patch (after a minor rebase). Sorry for breaking "hg annotation" on Include/abstract.h: I hope that it will be less annoying that the giant "replace tabs with space" made by Antoine Pitrou a few years ago which modified almost all .c and .h

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Serhiy Storchaka added the comment: Victor, it would be worth to discuss this change on Python-Dev. -- ___ Python tracker ___

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Roundup Robot added the comment: New changeset 654ec6ed3225 by Victor Stinner in branch 'default': Issue #28838: Cleanup abstract.h https://hg.python.org/cpython/rev/654ec6ed3225 -- ___ Python tracker

[issue28838] Using consistent naming for arguments of "call" functions (C API)

STINNER Victor added the comment: cleanup-2.patch: Rebase cleanup.patch. This patch is the last part of my work to cleanup Include/abstract.h to make it more consistent with other header files. -- Added file: http://bugs.python.org/file45798/cleanup-2.patch

[issue28838] Using consistent naming for arguments of "call" functions (C API)

STINNER Victor added the comment: Serhiy: > Seems most of comments that did not follow common style are your comments to > "fast call" functions. It would be better to fix only that comments. I would like to modify abstract.h because its weird style annoy me for years. I would like to make

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Serhiy Storchaka added the comment: > It don't think that my change makes abstract.h worse, some comments were far > from their declaration, and there is was no unique style for comments. It's > a mess. Seems most of comments that did not follow common style are your comments to "fast call"

[issue28838] Using consistent naming for arguments of "call" functions (C API)

STINNER Victor added the comment: I pushed another large patch to "fix" the indentation of abstract.h. I would prefer to also have this "reindent" change on review, but our reviewing tool doesn't support patch series :-( Attached cleanup.patch reformats deeply the header file to use the same

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Roundup Robot added the comment: New changeset 69c7451c3ec1 by Victor Stinner in branch 'default': Issue #28838: Fix weird indentation of abstract.h https://hg.python.org/cpython/rev/69c7451c3ec1 -- ___ Python tracker

[issue28838] Using consistent naming for arguments of "call" functions (C API)

Serhiy Storchaka added the comment: Oh, you have mixed up comments! In headers descriptions are written after function declarations. You have moved some comments and now some descriptions are placed below the corresponding declaration, and some descriptions are placed above. Now it is not

[issue28838] Using consistent naming for arguments of "call" functions (C API)

R. David Murray added the comment: "Uniformize" isn't really an English word :) -- nosy: +r.david.murray title: Uniformize argument names of "call" functions (C API) -> Using consistent naming for arguments of "call" functions (C API) ___ Python