[issue29062] hashlib documentation link error

Changes by INADA Naoki : -- status: open -> closed ___ Python tracker ___ ___

[issue29062] hashlib documentation link error

INADA Naoki added the comment: Martin, thank you for pointing it out. I hadn't know about suspicious check. -- ___ Python tracker ___

[issue29062] hashlib documentation link error

Roundup Robot added the comment: New changeset ea0c488b9bac by INADA Naoki in branch '3.6': Issue #29062: Doc: Fix make suspicious https://hg.python.org/cpython/rev/ea0c488b9bac New changeset 5c48fbe12cb8 by INADA Naoki in branch 'default': Issue #29062: Doc: Fix make suspicious

[issue29062] hashlib documentation link error

Martin Panter added the comment: Looks like Doc/tools/susp-ignored.csv needs updating: $ make -C Doc/ suspicious [. . .] writing output... [ 49%] library/hashlib WARNING: [library/hashlib:502] ":vatrogasac" found in ">>> cookie = b'user:vatrogasac'"

[issue29062] hashlib documentation link error

INADA Naoki added the comment: Thanks. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue29062] hashlib documentation link error

Roundup Robot added the comment: New changeset 799ed3122456 by INADA Naoki in branch '3.6': Issue #29062: Merge hashlib-blake2.rst into hashlib.rst https://hg.python.org/cpython/rev/799ed3122456 New changeset 380e63b7fc82 by INADA Naoki in branch 'default': Issue #29062: Merge

[issue29062] hashlib documentation link error

Christian Heimes added the comment: Go ahead if it makes your work easier. I kept the file separate because the blake2 documentation is maintained externally. It's not going to change any time soon, though. Let's merge it. -- ___ Python tracker

[issue29062] hashlib documentation link error

Xiang Zhang added the comment: Although I am +1 for merging it before but these days I find it's not the only case. There are also two unittest.mock entries. This is just FYI, no opinion on this issue. -- ___ Python tracker

[issue29062] hashlib documentation link error

INADA Naoki added the comment: @christian.heimes Would you look merge-hashlib-blake2.patch? This is blocker of our document translation project. -- ___ Python tracker

[issue29062] hashlib documentation link error

Changes by Serhiy Storchaka : -- nosy: +martin.panter, r.david.murray ___ Python tracker ___

[issue29062] hashlib documentation link error

INADA Naoki added the comment: May I commit merge-hashlib-blake2.patch to 3.6 branch? -- ___ Python tracker ___

[issue29062] hashlib documentation link error

Changes by INADA Naoki : Added file: http://bugs.python.org/file46051/merge-hashlib-blake2.patch ___ Python tracker ___

[issue29062] hashlib documentation link error

INADA Naoki added the comment: > INADA, 3.6 branch also suffers the problems here, I didn't see you patch it. Oh, I'm sorry. I'll update 3.6 branch in next time. -- ___ Python tracker

[issue29062] hashlib documentation link error

INADA Naoki added the comment: > That is because hashlib-blake2.rst is explicitly added to the TOC list in > Doc/library/crypto.rst. Yes. All rst should be explicitly added by `toctree` or `include`. In this case, I feel there are no reason to use `include` directive instead of merging two

[issue29062] hashlib documentation link error

Serhiy Storchaka added the comment: > While section level of Module, Examples, and Credits is fixed, > https://docs.python.org/3/library/crypto.html seems still weird. > It looks like there are two `hashlib` modules. That is because hashlib-blake2.rst is explicitly added to the TOC list in

[issue29062] hashlib documentation link error

Xiang Zhang added the comment: > Now I think hashlib-blake2 should be merged into hashlib. +1 INADA, 3.6 branch also suffers the problems here, I didn't see you patch it. -- ___ Python tracker

[issue29062] hashlib documentation link error

INADA Naoki added the comment: While section level of Module, Examples, and Credits is fixed, https://docs.python.org/3/library/crypto.html seems still weird. It looks like there are two `hashlib` modules. Now I think hashlib-blake2 should be merged into hashlib. -- resolution: fixed

[issue29062] hashlib documentation link error

Roundup Robot added the comment: New changeset c75ef013bca3 by INADA Naoki in branch 'default': Issue #29062: doc: Fix heading level of hashlib-blake2 https://hg.python.org/cpython/rev/c75ef013bca3 -- ___ Python tracker

[issue29062] hashlib documentation link error

Xiang Zhang added the comment: This fixed the index. But the section is still messed up: https://docs.python.org/3/library/crypto.html. The three entries: Module, Examples, Credits in my mind should not appear on the index. -- ___ Python tracker

[issue29062] hashlib documentation link error

Changes by INADA Naoki : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue29062] hashlib documentation link error

Roundup Robot added the comment: New changeset 1970c9ea8572 by INADA Naoki in branch 'default': Issue #29062: doc: Fix hashlib module index conflict https://hg.python.org/cpython/rev/1970c9ea8572 -- nosy: +python-dev ___ Python tracker

[issue29062] hashlib documentation link error

Serhiy Storchaka added the comment: I didn't tested my suggestion. If it solves the issue and makes all related references correct, feel free to push the patch Inada. -- assignee: docs@python -> inada.naoki stage: -> commit review ___ Python

[issue29062] hashlib documentation link error

INADA Naoki added the comment: I like currentmodule directive. -- keywords: +patch Added file: http://bugs.python.org/file46040/29062-currentmodule.patch ___ Python tracker

[issue29062] hashlib documentation link error

Serhiy Storchaka added the comment: Replace ".. module" with ".. currentmodule". -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue29062] hashlib documentation link error

INADA Naoki added the comment: 1. remove `.. module:: hashlib` from Doc/library/hashlib-blake2.rst 2. merge Doc/library/hashlib-blake2.rst content into Doc/library/hashlib.rst Hmm, which is better? -- nosy: +inada.naoki ___ Python tracker

[issue29062] hashlib documentation link error

Xiang Zhang added the comment: Is the https://docs.python.org/3/library/crypto.html section messed up? Two hashlib entries and some other bad entries? -- nosy: +xiang.zhang ___ Python tracker

[issue29062] hashlib documentation link error

Changes by Serhiy Storchaka : -- nosy: +christian.heimes, georg.brandl, gregory.p.smith title: Documentation link error -> hashlib documentation link error versions: +Python 3.7 ___ Python tracker