[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Changes by Donald Stufft : -- pull_requests: +1108 ___ Python tracker ___ ___

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: m-parry reported the issue #29921 "datetime validation is stricter in 3.6.1 than previous versions". He is right, the C API of Python 3.6.1 is now stricter than Python 2.7 and 3.5. The C API doesn't allow anymore to create datetime objects outside the

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset be363764cad68ad7b608ceed837cc01c2c3b4efc by Victor Stinner in branch '3.6': Fix test_datetime on Windows https://github.com/python/cpython/commit/be363764cad68ad7b608ceed837cc01c2c3b4efc -- ___ Python

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset be363764cad68ad7b608ceed837cc01c2c3b4efc by Victor Stinner in branch 'master': Fix test_datetime on Windows https://github.com/python/cpython/commit/be363764cad68ad7b608ceed837cc01c2c3b4efc -- ___

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset 1555e7776321 by Victor Stinner in branch '3.6': Fix test_datetime on Windows https://hg.python.org/cpython/rev/1555e7776321 -- ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset a88f9614c672c3369cf03cdf51d012a42ae5665f by Victor Stinner in branch 'master': Fix test_datetime on system with 32-bit time_t https://github.com/python/cpython/commit/a88f9614c672c3369cf03cdf51d012a42ae5665f --

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset 1c6b87b07586 by Victor Stinner in branch '3.6': Fix test_datetime on system with 32-bit time_t https://hg.python.org/cpython/rev/1c6b87b07586 -- ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset 5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f by Victor Stinner in branch 'master': Fix datetime.fromtimestamp(): check bounds https://github.com/python/cpython/commit/5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f --

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset 5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f by Victor Stinner in branch '3.6': Fix datetime.fromtimestamp(): check bounds https://github.com/python/cpython/commit/5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f --

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Roundup Robot added the comment: New changeset 383c0238b5b0 by Victor Stinner in branch '3.6': Fix datetime.fromtimestamp(): check bounds https://hg.python.org/cpython/rev/383c0238b5b0 -- nosy: +python-dev ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: I pushed timestamp_limits-2.patch. Thanks for the bug report Jordon Phillips, thanks for the review Serhiy Storshaka. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: timestamp_limits-2.patch: catch also OverflowError in unit tests, and uses a context manager rather than self.assertRaises(..., func, ...) syntax. -- Added file: http://bugs.python.org/file46437/timestamp_limits-2.patch

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: timestamp_limits.patch is waiting for your review! This issue is a major regression of Python 3.6. I'm going to push the patch in one week if I don't get any review. -- ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: The issue #29346 has been marked as a duplicate of this one. -- ___ Python tracker ___

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Changes by STINNER Victor : -- nosy: +Eli Collins, lemburg ___ Python tracker ___

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: timestamp_limits.patch: Add many checks in the _datetime module to avoid overflows or creating a object out of the range. The patch adds unit tests. The unit test checks dates around year 1 and year . I expect failures on platforms which only work well on

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: unitttest.patch: my attempt to write an unit test, but I was bitten by the datetime.timestamp() bug. -- Added file: http://bugs.python.org/file46131/unittest.patch ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

STINNER Victor added the comment: Oh, datetime.datetime.timestamp() also has a bug for values close to 0001-01-01 (year 1), at least in my timezone (CET). $ ./python -c 'import datetime; datetime.datetime.min.timestamp()' python: /home/haypo/prog/python/default/Modules/_datetimemodule.c:251:

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Changes by STINNER Victor : -- title: datetime.fromtimestamp() does crash for very small or very big timestamp -> datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6 ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

Changes by STINNER Victor : -- keywords: +3.6regression ___ Python tracker ___ ___