[issue29121] sqlite3 Controlling Transactions documentation not updated

Berker Peksag added the comment: New changeset fe70d924bb6106d4c21eb414f4a1ba1324e8f46a by Berker Peksag in branch 'master': bpo-29121: Remove outdated documentation about transactions (#313) https://github.com/python/cpython/commit/fe70d924bb6106d4c21eb414f4a1ba1324e8f46a --

[issue29121] sqlite3 Controlling Transactions documentation not updated

Berker Peksag added the comment: New changeset fe70d924bb6106d4c21eb414f4a1ba1324e8f46a by Berker Peksag in branch 'master': bpo-29121: Remove outdated documentation about transactions (#313) https://github.com/python/cpython/commit/fe70d924bb6106d4c21eb414f4a1ba1324e8f46a --

[issue29121] sqlite3 Controlling Transactions documentation not updated

Berker Peksag added the comment: New changeset 893e86e9d3c0caeb878ccb1120c7259e022f3b68 by Berker Peksag in branch '3.6': bpo-29121: Remove outdated documentation about transactions (#313) (#319) https://github.com/python/cpython/commit/893e86e9d3c0caeb878ccb1120c7259e022f3b68 --

[issue29121] sqlite3 Controlling Transactions documentation not updated

Berker Peksag added the comment: Thanks for the patch, Aviv! -- assignee: -> docs@python components: +Documentation nosy: +docs@python resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker

[issue29121] sqlite3 Controlling Transactions documentation not updated

Changes by Berker Peksag : -- pull_requests: +280 ___ Python tracker ___ ___

[issue29121] sqlite3 Controlling Transactions documentation not updated

Changes by Berker Peksag : -- pull_requests: +274 ___ Python tracker ___ ___

[issue29121] sqlite3 Controlling Transactions documentation not updated

Ma Lin added the comment: After read some issues, there are two major concerns: 1, backward compatibility. 2, implicit commit is bad, tolerates bug-prone codes. However they are not contradictory if we print a warning when doing an implicit commit. Some messages like this: Warning: sqlite3

[issue29121] sqlite3 Controlling Transactions documentation not updated

Changes by Ma Lin : -- nosy: +Ma Lin ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29121] sqlite3 Controlling Transactions documentation not updated

Aviv Palivoda added the comment: I would just like to note that I think that the correct solution is to do an implicit commit before: 1. VACUUM 2. ATTACH 3. DETACH 4. BEGIN -- ___ Python tracker

[issue29121] sqlite3 Controlling Transactions documentation not updated

New submission from Aviv Palivoda: commit 284676cf2ac8 changed the sqlite3 module so it will no longer implicitly commit an open transaction before DDL statements. The docs have been updated but there is still an incorrect paragraph that has not been removed. Attached is a patch that remove