[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Senthil Kumaran added the comment: Thank you for the review, Julian. Addressed it and the change is committed at changeset b5125e971fdd -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Julian Berman added the comment: Cool! If I can nitpick one last time, in the versionchanged block, you have `HTTPS URIs` but in the warning you use `HTTPS Urls` -- probably best to use consistent casing and URL vs URI. Other than that, lgtm to merge. --

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Senthil Kumaran added the comment: Hi Julian, here is the patch that addresses you comments. Thanks -- Added file: http://bugs.python.org/file46430/issue29182-patch3.diff ___ Python tracker

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Julian Berman added the comment: The change note belongs outside the seealso. I think also that wasn't exactly what Martin had in mind, I think he meant a `.. versionchanged` directive -- and given that this was originally a warning, personally I'd leave the warning but reword it, it's still

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Senthil Kumaran added the comment: Here is the updated patch that addresses the comment. -- Added file: http://bugs.python.org/file46401/issue29182_docs_fix.patch ___ Python tracker

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Senthil Kumaran added the comment: @Martin, that's a sound advice. I agree to it. I'll change it to a note (instead of warning) which mentions about certificate verification since 2.7.9. -- ___ Python tracker

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Martin Panter added the comment: The warning for urllib2.urlopen() was removed in revision 1882157b298a. However, a couple other warnings were converted to “Changed in version 2.7.9” in revision fb83916c3ea1, which seems safer to me. Removing documentation almost seems like a step backwards.

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker ___

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

New submission from Senthil Kumaran: It started as a discussion in this issue: http://bugs.python.org/issue22417#msg284604 I think, that warning can be removed. If no one has any objections, I will commit this attached patch. -- assignee: orsenthil components: Documentation files: