[issue29191] liblzma is missing from pcbuild.sln

2017-04-21 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks everyone :) I merged the backport PR, so I'm closing this issue. While backporting is still a manual effort, this utility script automates some part of it. https://github.com/python/core-workflow/tree/master/cherry_picker -- resolution: ->

[issue29191] liblzma is missing from pcbuild.sln

2017-04-21 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 1ccbe6007e5569ab25170f8ecddd5fbbc2ef36b0 by Mariatta (Steve Dower) in branch '3.6': bpo-29191: Add liblzma.vcxproj to pcbuild.sln and other missing entries (GH-1222) (GH-1244)

[issue29191] liblzma is missing from pcbuild.sln

2017-04-21 Thread Steve Dower
Changes by Steve Dower : -- pull_requests: +1362 ___ Python tracker ___ ___

[issue29191] liblzma is missing from pcbuild.sln

2017-04-21 Thread Steve Dower
Steve Dower added the comment: Yeah, merging into master is easy right now, but backports are still manual effort. It should only require 3.6, so I'll try to get to it today. -- ___ Python tracker

[issue29191] liblzma is missing from pcbuild.sln

2017-04-21 Thread Segev Finer
Segev Finer added the comment: The PR was merged for Python 3.7. But this also affects older Python 3 versions that include liblzma/_lzma as far as I can tell. So I'm not closing this issue just yet, so that it will serve as a remainder, in case you do want to back port this. Thanks for

[issue29191] liblzma is missing from pcbuild.sln

2017-04-20 Thread Steve Dower
Steve Dower added the comment: New changeset f60c9e54f501065f3be2a4cfb4c387dfa2f243a9 by Steve Dower (Segev Finer) in branch 'master': bpo-29191: Add liblzma.vcxproj to pcbuild.sln and other missing entries (#1222)

[issue29191] liblzma is missing from pcbuild.sln

2017-04-20 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +1345 ___ Python tracker ___ ___

[issue29191] liblzma is missing from pcbuild.sln

2017-02-23 Thread Steve Dower
Changes by Steve Dower : -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue29191] liblzma is missing from pcbuild.sln

2017-02-23 Thread Mo Jia
Mo Jia added the comment: I think let user add the liblzma project by hand is not good enough. While the build.bat don't have this problem. So they should work similar. -- nosy: +Mo.Jia versions: -Python 3.5, Python 3.6 ___ Python tracker

[issue29191] liblzma is missing from pcbuild.sln

2017-01-07 Thread Steve Dower
Steve Dower added the comment: LGTM. Though as you say, it's probably easiest for one of us to go through each branch and use VS to get it right. I think both of those projects were added from other operating systems, so updating the sln wouldn't be so easy. I'll get to it at some point

[issue29191] liblzma is missing from pcbuild.sln

2017-01-07 Thread Segev Finer
New submission from Segev Finer: liblzma is missing from pcbuild.sln. This causes the build of _lzma to fail when building the solution and not using build.bat. Attached is a patch that fixes this for the default branch. Note that it also includes some missing project configurations for the