[issue29237] Create enum for pstats sorting options

Ethan Furman added the comment: Thanks for catching that! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29237] Create enum for pstats sorting options

Cheryl Sabella added the comment: Can this one be closed since it was an enhancement and doesn't need to be backported? -- nosy: +csabella ___ Python tracker

[issue29237] Create enum for pstats sorting options

Change by Ethan Furman : -- pull_requests: +5183 ___ Python tracker ___ ___

[issue29237] Create enum for pstats sorting options

Ethan Furman added the comment: New changeset 863b1e4d0e95036bca4e97c1b8b2ca72c19790fb by Ethan Furman (mwidjaja) in branch 'master': bpo-29237: Create enum for pstats sorting options (GH-5103)

[issue29237] Create enum for pstats sorting options

Change by Marcel Widjaja : -- keywords: +patch pull_requests: +4972 stage: needs patch -> patch review ___ Python tracker ___

[issue29237] Create enum for pstats sorting options

Marcel Widjaja added the comment: I'd like to try to work on this one -- nosy: +mawidjaj ___ Python tracker ___

[issue29237] Create enum for pstats sorting options

Mariatta Wijaya added the comment: Thanks for checking in, Ethan. Sorry, since this was first assigned to me, I got pre-occupied with other issues and projects in the core-workflow. Ratnadeep, if you are still interested, please go ahead with this issue. I've unassigned myself. Thanks.

[issue29237] Create enum for pstats sorting options

Ethan Furman added the comment: Marriatta, perhaps it is time to let Ratnadeep work on this issue? -- ___ Python tracker ___

[issue29237] Create enum for pstats sorting options

Louie Lu added the comment: Mariatta, is there any movement on this issue? Thanks! -- nosy: +louielu ___ Python tracker ___

[issue29237] Create enum for pstats sorting options

Ratnadeep Debnath added the comment: It's good to hear that you're working on it. You can go ahead with this. Anyways, I will be around to see and learn how you fix this issue :) -- ___ Python tracker

[issue29237] Create enum for pstats sorting options

Mariatta Wijaya added the comment: Thank you, Ratnadeep. I've been assigned to this issue, and have made some progress on it. I'm away for a conference right now, and I plan on getting back once I'm back. Will it be possible for you to work on a different issue? Thanks. --

[issue29237] Create enum for pstats sorting options

Ratnadeep Debnath added the comment: I am taking up to create a patch/pull request for this to get it reviewed. -- nosy: +rtnpro ___ Python tracker ___

[issue29237] Create enum for pstats sorting options

Raymond Hettinger added the comment: Mariatta, would you like to prepare a patch for this. Ethan and I will review it. -- assignee: -> Mariatta nosy: +Mariatta, rhettinger ___ Python tracker

[issue29237] Create enum for pstats sorting options

Ethan Furman added the comment: To keep backwards compatibility and lesson the burden on new code, simply make the value of the duplicate names be the same: cumulative = 'cumulative' cumtime = 'cumulative' This way the standard name is 'cumulative' but 'cumtime' works as well.

[issue29237] Create enum for pstats sorting options

New submission from Thane Brimhall: When using the cProfile and pstats modules, I often forget which string keys are available for sorting. It would be nice to add an enum for these so a user could have their linter and IDE check that value pre-runtime. By subclassing both `str` and `Enum`