[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Andrew Svetlov added the comment: Is the issue done? Can it be closed? -- nosy: +asvetlov ___ Python tracker ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Brett Cannon added the comment: To be honest, I'm not excited by ./configure --enable-optimizations. I was happy with an explicit "make profile-opt". The configure flag was added because not everything can be enabled just in the Makefile and so that people have a single flag to set to turn on

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Tomas Orsava added the comment: > Oh wait, I expected that "make test" would build Python with PGO, but it > doesn't anymore. Would it be possible to change the Makefile to make sure > that "make python" (on Linux, "make python.exe" on macOS) would build Python > using PGO? > > I tried to hack

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

STINNER Victor added the comment: Oh wait, I expected that "make test" would build Python with PGO, but it doesn't anymore. Would it be possible to change the Makefile to make sure that "make python" (on Linux, "make python.exe" on macOS) would build Python using PGO? I tried to hack

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Gregory P. Smith added the comment: Yes, this appears true. I'm okay with it because I've always considered the make, test, and install as different command invocations. The package building automation I am aware of tends to do the same. Our buildbots keep the steps separate. But we need

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Xiang Zhang added the comment: > I don't think that the patch changes the behaviour of "make": it only > changes the behaviour of "make install" and "make test" (and a few > others). I don't mean "make" is changed. I mean the latter. Before, a single "make test" or "make install" will do all

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

STINNER Victor added the comment: Xiang Zhang added the comment: > So now we have to run make if we want to trigger the profile procedure since > other make commands like make test won't trigger the procedure by itself, > right? I don't think that the patch changes the behaviour of "make": it

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Xiang Zhang added the comment: So now we have to run make if we want to trigger the profile procedure since other make commands like make test won't trigger the procedure by itself, right? -- ___ Python tracker

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

STINNER Victor added the comment: New changeset a473a73d0cb42c534a3047bbf781b3c592fc33ca by Victor Stinner (torsava) in branch '2.7': [2.7] bpo-29243: Fix Makefile with respect to --enable-optimizations (GH-1478) (#1522)

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Changes by Tomas Orsava : -- pull_requests: +1621 ___ Python tracker ___ ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

STINNER Victor added the comment: New changeset 8489409bbfabb2ddc30ed55c9f4d679a3710ebe4 by Victor Stinner (torsava) in branch '3.5': [3.5] bpo-29243: Fix Makefile with respect to --enable-optimizations (GH-1478) (#1520)

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Changes by Tomas Orsava : -- pull_requests: +1620 ___ Python tracker ___ ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

STINNER Victor added the comment: New changeset 03b8a378dfa46372b96790f82c85e9b72518f1bf by Victor Stinner (torsava) in branch '3.6': [3.6] bpo-29243: Fix Makefile with respect to --enable-optimizations (GH-1478) (#1518)

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Changes by Tomas Orsava : -- pull_requests: +1618 ___ Python tracker ___ ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

STINNER Victor added the comment: I closed my issue #29641 as a duplicate of this one. -- ___ Python tracker ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

STINNER Victor added the comment: New changeset a1054c3b0037d4c2a5492e79fc193f36245366c7 by Victor Stinner (torsava) in branch 'master': bpo-29243: Fix Makefile with respect to --enable-optimizations (#1478) https://github.com/python/cpython/commit/a1054c3b0037d4c2a5492e79fc193f36245366c7

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Tomas Orsava added the comment: I've opened a PR#1478 that I believe fixes the issue. -- nosy: +torsava ___ Python tracker ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Changes by Tomas Orsava : -- pull_requests: +1577 ___ Python tracker ___ ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Changes by Charalampos Stratakis : -- nosy: +cstratak ___ Python tracker ___ ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Xiang Zhang added the comment: Another complaint from #29889. -- ___ Python tracker ___ ___ Python-bugs-list

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

INADA Naoki added the comment: That's why I want to enable only --with-lto -- nosy: +inada.naoki ___ Python tracker ___

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

Brett Cannon added the comment: Since optimizations uses PGO which should do a fresh run, that's why there's the clearing of the state. I'm personally not bothered by it as you really should only being doing an optimized build once when you do the first install and then you're done. But if

[issue29243] --enable-optimizations makes common build commands always need to compile from scratch

New submission from Xiang Zhang: In 3.6 we get --enable-optimizations. One thing I find annoyed with this flag is that it makes some build commands compile from scratch since it always clears the environment first. For example, with the commands listed at the top of Makefile: ./configure