[issue29289] Convert OrderedDict methods to Argument Clinic

2017-02-01 Thread STINNER Victor
STINNER Victor added the comment: Thanks again Serhiy for the better docstrings! Known issues are now fixed, so I close the issue. Thanks for the review Naoki. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset ffc0840762e4 by Serhiy Storchaka in branch 'default': Issues #29311, #29289: Fixed and improved docstrings for dict and OrderedDict https://hg.python.org/cpython/rev/ffc0840762e4 -- ___ Python tracker

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset c144bf6c0ff7 by Serhiy Storchaka in branch 'default': Issue #29289: Argument Clinic generates reasonable name for the parameter "default". https://hg.python.org/cpython/rev/c144bf6c0ff7 -- ___ Python

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have added other comments on Rietveld (mostly about docstrings). -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-17 Thread STINNER Victor
STINNER Victor added the comment: For OrderedDict.pop(), I created the issue #29299: "Argument Clinic: Fix signature of optional positional-only arguments". -- ___ Python tracker

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-16 Thread STINNER Victor
STINNER Victor added the comment: Oh, I missed Naoki's comment on the review :-/ I got the notification of this review after I pushed the change. I will fix the docstring later. -- ___ Python tracker

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-16 Thread STINNER Victor
STINNER Victor added the comment: Raymond: " The argument clinic doesn't cope well with optional arguments without a default value." Right, it's a bug in AC. I will try to fix it later. In the meanwhile, I pushed the first uncontroversal part. --

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9f7d16266928 by Victor Stinner in branch 'default': Convert some OrderedDict methods to Argument Clinic https://hg.python.org/cpython/rev/9f7d16266928 -- nosy: +python-dev ___ Python tracker

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-16 Thread INADA Naoki
INADA Naoki added the comment: LGTM, except pop(). -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-16 Thread Raymond Hettinger
Raymond Hettinger added the comment: This patch segfaults for me (Mac OS 10.12.2 with the default clang-800.0.42.1). For now, pop() should be omitted. The argument clinic doesn't cope well with optional arguments without a default value. The generated help "pop(self, /, key, default=None)"

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-16 Thread STINNER Victor
STINNER Victor added the comment: Converted methods: * fromkeys() (@classmethod) * setdefault() * pop() * popitem() * move_to_end() -- ___ Python tracker

[issue29289] Convert OrderedDict methods to Argument Clinic

2017-01-16 Thread STINNER Victor
New submission from STINNER Victor: Attached patch converts methods using METH_VARARGS|METH_KEYWORDS calling convention to METH_FASTCALL using Argument Clinic. This calling convention is faster, and Argument Clinic provides better docstring. See also issue #29263 "Implement