[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-19 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Ammar. :-) -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset bb76ea32a32f by Xiang Zhang in branch '3.5': Issue #29292: Update outdated doc of PyEval_EvalCodeEx. https://hg.python.org/cpython/rev/bb76ea32a32f New changeset bd121b7517ee by Xiang Zhang in branch '3.6': Issue #29292: Merge 3.5.

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-19 Thread Ammar Askar
Ammar Askar added the comment: Updated patch to include a cross reference to keyword-only arguments since I think not everyone will know about this rather new feature. -- Added file: http://bugs.python.org/file46349/kwdefs_docs.diff4 ___ Python

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-19 Thread Ammar Askar
Ammar Askar added the comment: Updated patch for review comments -- Added file: http://bugs.python.org/file46348/kwdefs_docs.diff3 ___ Python tracker ___

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-18 Thread Ammar Askar
Changes by Ammar Askar : Added file: http://bugs.python.org/file46332/kwdefs_docs.diff2 ___ Python tracker ___

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-18 Thread Ammar Askar
Ammar Askar added the comment: You're completely right, the kwdefs is referring to default arguments for keyword-only-arguments from this PEP: https://www.python.org/dev/peps/pep-3102/ Where as that line is probably referring to "defs", the defaults for normal parameters. I'll upload an

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-17 Thread Xiang Zhang
Xiang Zhang added the comment: > "keywords and defaults," however, the kwdefs argument was never added to the > prototype. I don't think this is about the missing "kwdefs". I think "arrays of arguments, keywords and defaults" is a whole part describing "PyObject **args, int argcount,

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-17 Thread Ammar Askar
Ammar Askar added the comment: It looks like a basic description of kwdefs was added as part of this commit: https://github.com/python/cpython/commit/7811a5d1c93f2aa0b357444eeb3f1ddc242ac57a "keywords and defaults," however, the kwdefs argument was never added to the prototype. I've attached

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-17 Thread Xiang Zhang
Changes by Xiang Zhang : -- keywords: +easy stage: -> needs patch ___ Python tracker ___

[issue29292] Missing a parameter in PyEval_EvalCodeEx doc

2017-01-17 Thread Xiang Zhang
New submission from Xiang Zhang: The signature of PyEval_EvalCodeEx now gets a "PyObject *kwdefs" parameter but the doc doesn't mention it. -- assignee: docs@python components: Documentation messages: 285620 nosy: docs@python, xiang.zhang priority: normal severity: normal status: open