[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Changes by Donald Stufft : -- pull_requests: +1007 ___ Python tracker ___ ___

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Ned Deily added the comment: The fix looks good and the dmg buildbots are happy again. Thanks, Martin and David. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Martin Panter added the comment: I pushed the simpler 2.6-compatible option. Keeping this open to check the buildbot is happy overnight. -- stage: needs patch -> resolved ___ Python tracker

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Roundup Robot added the comment: New changeset 9880928ec962 by Martin Panter in branch '3.5': Issue #29349: Use __future__ print_function; Sphinx may use Python 2.6+ https://hg.python.org/cpython/rev/9880928ec962 New changeset 1708afd284ff by Martin Panter in branch '3.6': Issues #29349: Merge

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

David Bolen added the comment: Whoops, I just realized that the patch still needs adjusting to be 2.x compatible, so obviously the extra build still won't work. But at this point it should be safe to assume 2.6+ such as for the rest of the sphinx processing. --

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

David Bolen added the comment: 2.7.12 (/usr/local/bin) is used for the build slave and main external commands (such as hg and sphinx) and is in the buildslave path, but 2.5.1 is still the default in /usr/bin so can get used for processes with a restricted environment. Tiger's original 2.3 is

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Martin Panter added the comment: According to , Ned says 2.6+ is already needed to build the Python 3.5 documentation, so maybe Sphinx uses that. -- ___ Python tracker

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Ned Deily added the comment: Dunno for sure, perhaps David can answer that. But the Sphinx docs imply that Sphinx 1.4.6 requires at least 2.6 and I don't test the installer build with anything less than 2.7. -- ___ Python tracker

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Martin Panter added the comment: Thanks Ned. Do you know what version of Python Sphinx uses (which runs patchlevel.py)? According to Issue 28039, David set up Python 2.7 so that “make touch” would work. But the log also uses a python2.5 command, and apparently Python 2.3 also installed on

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Ned Deily added the comment: These changes have broken some buildbots, for example, the OS X dmg buildbots which are still using Python 2 for sphinx builds of the docs. They should be version agnostic as much as possible. http://buildbot.python.org/all/builders/bolen-dmg-3.x/builds/59

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Martin Panter added the comment: I think the general rule is to clean up code if you are doing something else in nearby code, but don’t go out of your way with unnecessary cleanups to arbitrary code. Otherwise it adds too much noise to the repository history, review process, risks adding

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Roundup Robot added the comment: New changeset ecdc864884a9 by Martin Panter in branch '3.5': Issue #29349: Fix Python 2 syntax in documentation build code https://hg.python.org/cpython/rev/ecdc864884a9 New changeset cdcb33f37bf3 by Martin Panter in branch '3.6': Issues #29349: Merge Py 2 fix

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Changes by Jim Fasarakis-Hilliard : Added file: http://bugs.python.org/file46406/patchlevel_with.patch ___ Python tracker ___

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Jim Fasarakis-Hilliard added the comment: I'm breaking these to separate files to make it easier to apply. I also noticed that other files in `Doc/tools/extensions/` use old constructs so I'm not sure about the *with*. I'm guessing that either it should be changed in other files too or, since

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

Martin Panter added the comment: Is it okay to only fix this in 3.5+? 3.4 only gets security fixes now. Either way, the “with” statement changes is not a bug fix and should only go into 3.7. -- nosy: +martin.panter stage: -> commit review ___

[issue29349] Update old Python 2 code in Docs/tools/extensions/patchlevel.py

New submission from Jim Fasarakis-Hilliard: There's a hidden Python 2 print call in the script that only gets reached after you move the Doc/ folder outside the main CPython directory and run `make html`. Additionally, an obsolete way of assuring a file gets closed is used (changed to use