[issue29387] Tabs vs spaces FAQ out of date

Changes by Mariatta Wijaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29387] Tabs vs spaces FAQ out of date

Mariatta Wijaya added the comment: Thanks, Martin, and thanks Jim for the ping. I'll backport the change to 2.7 later today, and then this issue can be closed :) -- assignee: docs@python -> Mariatta ___ Python tracker

[issue29387] Tabs vs spaces FAQ out of date

Martin Panter added the comment: The “tabnanny” script was removed from Tools/scripts/ in 2.0: . So the 2.7 FAQ also has the wrong location. -- ___ Python tracker

[issue29387] Tabs vs spaces FAQ out of date

Mariatta Wijaya added the comment: Just a question, does this need backport to 2.7? It's only been backported to 3.5 and 3.6. -- nosy: +Mariatta ___ Python tracker

[issue29387] Tabs vs spaces FAQ out of date

Jim Fasarakis-Hilliard added the comment: Shouldn't this issue get closed now that the PR was merged? -- nosy: +Jim Fasarakis-Hilliard ___ Python tracker

[issue29387] Tabs vs spaces FAQ out of date

Mariatta Wijaya added the comment: New changeset 38c8354f3204441f6c6bd22213b449d2d8954fcc by GitHub in branch '3.5': bpo-29521 Fix two minor documentation build warnings (#41) (#84) https://github.com/python/cpython/commit/38c8354f3204441f6c6bd22213b449d2d8954fcc -- nosy: +Mariatta

[issue29387] Tabs vs spaces FAQ out of date

Brian Curtin added the comment: New changeset 3d707be950b387552585451071928e7b39cdfa53 by Brian Curtin in branch 'master': bpo-29521 Fix two minor documentation build warnings (#41) https://github.com/python/cpython/commit/3d707be950b387552585451071928e7b39cdfa53 -- nosy:

[issue29387] Tabs vs spaces FAQ out of date

Jim DeLaHunt added the comment: PR https://github.com/python/cpython/pull/41 to the new Github repo contains the following wording in Doc/faq/windows.rst: Python raises :exc:`IndentationError` or :exc:`TabError` if mixed tabs and spaces are causing problems in leading whitespace. You may also

[issue29387] Tabs vs spaces FAQ out of date

Marco Buttu added the comment: Thanks Jim. I tested thise exec() in Py2.7 and Py3 (3.5 - 3.7): exec("if True:\n" + " "*width + "1\n" + "\t2\n") * width == 0 raises a IndentationError both in Py2 and Py3 * width in range(1, 8) raises an IndentationError in Py2 and TabError in Py3 * width == 8

[issue29387] Tabs vs spaces FAQ out of date

Jim DeLaHunt added the comment: I just created Pull Request 76 https://github.com/python/cpython/pull/76 to address http://bugs.python.org/issue29521 . In faq/windows.rst, I've used your wording from the discussion in of this bug. I may have address this issue completely, in fact. I did

[issue29387] Tabs vs spaces FAQ out of date

Terry J. Reedy added the comment: I would add the exception type after testing all versions patched. -- ___ Python tracker ___

[issue29387] Tabs vs spaces FAQ out of date

Marco Buttu added the comment: I think you are right about the TAB model (Parser/tokenizer.c:40 and Lib/tokenize.py:215), that is why the difference between the two cases. In any case, I am not sure whether expliciting the type of the exeption is the best choice. So, to me +1 to just change

[issue29387] Tabs vs spaces FAQ out of date

Martin Panter added the comment: Marco: I agree “Python reports an error” would have been simpler. That is what I meant to say. Anyway, perhaps we should put Python raises :exc:`IndentationError` if mixed tabs and spaces are causing problems in leading whitespace. In general, the exception

[issue29387] Tabs vs spaces FAQ out of date

Terry J. Reedy added the comment: I agree with Marco in that I do not understand the 'should'. Py 3 has a definite rule for when it raises. (I don't remember the exact details as I don't use tabs.) "Python raises xxxError if one mixes tabs and spaces in the same file." (Or whatever the

[issue29387] Tabs vs spaces FAQ out of date

Xiang Zhang added the comment: LGTM. -t is not removed but only ignored in Py3 for backwards compatibility. And I am fine with the wording. -- nosy: +xiang.zhang ___ Python tracker

[issue29387] Tabs vs spaces FAQ out of date

Marco Buttu added the comment: Hi Martin, why did you write "Python should report an error if mixed tabs and spaces are causing problems in leading whitespace."? Python for sure reports an error in that case. Maybe "Python reports an error if..." is a better choice. But my English is really

[issue29387] Tabs vs spaces FAQ out of date

New submission from Martin Panter: The Windows FAQ mentions the “python -t” command-line option, but in Python 3 this option is undocumented (and I understand has no