[issue29414] Change 'the for statement is such an iterator' in Tutorial

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Raymond Hettinger added the comment: New changeset 218e47b61862470477922e9aba1a23fd3dab18ae by Raymond Hettinger (Marco Buttu) in branch 'master': bpo-29414: Change 'the for statement is such an iterator' in Tutorial (GH-273)

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Marco Buttu added the comment: > I don't see this point. The other section titles are not about > loops. The preceding chapter introduces while loops as a loop, > not a statement, and this chapter talks about while and for > loops further down the page. What I mean is that currently in every

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Wolfgang Maier added the comment: > [...] I prefere the chapter as it currently is, because IMHO it > introduces the concepts more gradually than your proposal. That's ok! It's your PR and I only wanted to show an alternative. I was hoping for a bit more people to provide feedback though. The

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Marco Buttu added the comment: Wolfgang, thanks for your contribution. However, I prefere the chapter as it currently is, because IMHO it introduces the concepts more gradually than your proposal. In addition the modification of the title section from "for Statements" to "for Loops" IMHO

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Wolfgang Maier added the comment: I studied the github PR and thought about it carefully, and that made me come to believe that the chapter deserves a larger rewrite not just of one section, but of several. I'm attaching my proposed change as a "classical" patch here for discussion. I hope

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Changes by Berker Peksag : -- stage: -> patch review type: -> enhancement ___ Python tracker ___

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Changes by Marco Buttu : -- pull_requests: +245 ___ Python tracker ___ ___

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Jim Fasarakis-Hilliard added the comment: Go ahead with making the PR, marco. I'll take a look at it too when you do. -- ___ Python tracker ___

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Marco Buttu added the comment: Hello Jim, do you have the time to make a pull request? Let me know, otherwise I will do it -- ___ Python tracker ___

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Marco Buttu added the comment: Even though the Terry suggestion is formally correct, we are just at the beginning of the tutorial, and unluckily the tuples have not been introduced yet. To avoid adding to much complication here, IMHO we can just left the preceding sentences as they are.

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Jim Fasarakis-Hilliard added the comment: Agreed. The issue I see with the additional suggestions by you and Marco (p.s the English was perfect!) is the introduction of other functions and/or objects that haven't been introduced yet. If you want to draw parallels with tuples, you'll need to

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Terry J. Reedy added the comment: The preceding sentences are also off. "In many ways the object returned by range() behaves as if it is a list, but in fact it isn’t. It is an object which returns the successive items of the desired sequence when you iterate over it, but it doesn’t really

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Marco Buttu added the comment: I agree with you that the current sentence: "We have seen that the for statement is such an iterator" is wrong. But also the new sentence IMHO is confusing, because it stills compare statementes with objects: "the for statement expects an object that is

[issue29414] Change 'the for statement is such an iterator' in Tutorial

Changes by Jim Fasarakis-Hilliard : -- keywords: +patch Added file: http://bugs.python.org/file46482/issue29414.patch ___ Python tracker

[issue29414] Change 'the for statement is such an iterator' in Tutorial

New submission from Jim Fasarakis-Hilliard: The current line is confusing hinting that the for statement is actually an object, it also makes a reference to iterators which the tutorial doesn't disambiguate until the chapter on Classes. I've added a small patch that, in my opinion, makes it