[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: New changeset 93602e3af70d3b9f98ae2da654b16b3382b68d50 by Nick Coghlan in branch '3.5': [3.5] bpo-29537: Tolerate legacy invalid bytecode (#169) https://github.com/python/cpython/commit/93602e3af70d3b9f98ae2da654b16b3382b68d50 --

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: New changeset 0410bee6e6c87f37e91f6cae3627d8e3704075f1 by Nick Coghlan in branch '3.5': bpo-29537: Also cover 3.5.2 in NEWS entry https://github.com/python/cpython/commit/0410bee6e6c87f37e91f6cae3627d8e3704075f1 --

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Changes by Nick Coghlan : -- pull_requests: +459 ___ Python tracker ___ ___

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: Merged (with test cases) in https://github.com/python/cpython/commit/93602e3af70d3b9f98ae2da654b16b3382b68d50 The test cases even cover ensuring the backwards compatibility also applies to frozen bytecode :) -- resolution: -> fixed stage: patch review

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: I just realised I need to add some test cases to test_importlib/source/test_file_loader.py before merging it, but since Larry hasn't objected to the proposed approach, I'm going to go ahead and implement this fix. --

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Iryna added the comment: If I may ask, what was the decision on this matter? We are planning to rebase Python 3.5 for Fedora and this currently blocks us, if we do not work this around with a patch. Let me know if there is anything I can help with to speed up the process. --

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: I updated the PR to cover both Serhiy's change to make the legacy bytecode safe to interpret, and a tweaked version of Petr's change to allow the legacy bytecode to be imported. The main tweaks to the latter were: - more in depth comments explaining the

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: For easier cross-referencing, note that http://bugs.python.org/issue29514 is the issue proposing a test case that ensures future maintainers are aware of the practical problems created by bumping the bytecode magic number in a maintenance release. --

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Changes by Nick Coghlan : -- type: -> behavior ___ Python tracker ___ ___

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: In putting together a PR for this, I think it *only* makes sense if we also push Petr's change upstream to accept the legacy bytecode files in 3.5.4+. The reason is that the patch actually causes a test case to fail due to "f()" change to "function" in an error

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Changes by Nick Coghlan : -- pull_requests: +135 ___ Python tracker ___ ___

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Changes by Iryna : -- nosy: +ishcherb ___ Python tracker ___ ___ Python-bugs-list

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Nick Coghlan added the comment: Thanks Serhiy, I think that will work well downstream in combination with Petr's patch to accept both magic numbers. -- ___ Python tracker

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

New submission from Serhiy Storchaka: Proposed patch is an alternative fix of issue27286 for Python 3.5. Rather than fixing the compiler and bumping the magic number it just avoids using incorrect value in eval loop. The patch can be useful for disro maintainers that don't want to recompile

[issue29537] Alternative fix for BUILD_MAP_UNPACK_WITH_CALL opcode in 3.5

Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file46634/BUILD_MAP_UNPACK_WITH_CALL-no-function_location.patch ___ Python tracker