[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Gregory P. Smith added the comment: I'm making progress on https://bugs.python.org/issue37901 and related IPv6-only issues, the changes of which tend to shake out improper uses of 127.0.0.1 hardcoded. I'm closing this issue as there aren't specific needs that the rest won't cover.

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Gregory P. Smith added the comment: LOL. That is a very strange story and the last thing i'd have expected to fall out from changing one string to another. :) -- ___ Python tracker

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

STINNER Victor added the comment: I would like to share a short story with you. I'm working on fixing *all* bugs on our 3 CI (buildbots, Travis CI, AppVeyor). I fixed almost all random test failures. Right now, I'm trying to fix all "dangling thread" warnings: bpo-31234. I was sure that I

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

R. David Murray added the comment: Users on linux can and do screw this up too. I believe we also had a case where a distro screwed up the defaults for, I think, the reverse resolve? Not sure which test that was, and the test may since been fixed to not depend on that. The point is this

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Gregory P. Smith added the comment: New changeset efb1d0a3c001a6153211063ba439b9847aa03509 by Gregory P. Smith in branch 'master': bpo-29639: change test.support.HOST to "localhost" https://github.com/python/cpython/commit/efb1d0a3c001a6153211063ba439b9847aa03509 --

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Changes by Gregory P. Smith : -- keywords: +patch pull_requests: +3457 stage: -> patch review ___ Python tracker ___

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Gregory P. Smith added the comment: great! that makes me feel much less bad about fixing this in the way i desire. :) -- ___ Python tracker ___

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Steve Dower added the comment: As far as I recall, there's a hosts file that resolves localhost to 127.0.0.1 on Windows, which means a user could break their own configuration if they so desired. Definitely on all supported versions we should be able to assume localhost can be resolved. I

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Brian Curtin added the comment: I echo Paul. I think the last time I would have seen a problem was on Windows 2000, which is unsupported per PEP-11. +1 to using localhost -- nosy: +brian.curtin ___ Python tracker

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Paul Moore added the comment: I have a vague recollection of once working on a (Windows) system that mis-resolved localhost. But it was a long time ago, and I'm 100% OK with calling such a system broken. +1 on using localhost -- ___ Python tracker

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

Antoine Pitrou added the comment: I'm not sure how much of the original analysis was right. I've just fired up a network-less Windows VM and 'localhost' seems to resolve just fine: >>> socket.gethostbyname('localhost') '127.0.0.1' >>> socket.getaddrinfo('localhost', 80, socket.AF_UNSPEC,

[issue29639] test suite intentionally avoids referring to localhost, destroying abstraction away from IPv6 vs IPv4

New submission from Gregory P. Smith: I am working on fixing our test suite to run on IPv6 only hosts (which are becoming a reality). Many failures today occur because of hard coded 127.0.0.1 values. This is wrong. We should refer to "localhost" The "solution" to