[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

STINNER Victor added the comment: I backported commit a86339b83fbd0932e0529a3c91935e997a234582 from master: commit 3243f8c1fb16b6de73f1d7a30f5d09047553bce3, but I don't have access to arm64, so I cannot test if the backport fixes test_ctypes on arm64. --

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

STINNER Victor added the comment: New changeset 3243f8c1fb16b6de73f1d7a30f5d09047553bce3 by Victor Stinner in branch '2.7': bpo-29565: Corrected ctypes passing of large structs by value on Windows AMD64 (GH-168) (GH-8625)

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

STINNER Victor added the comment: This issue is mentioned from https://bugzilla.redhat.com/show_bug.cgi?id=1336557 but it seems like the bug has not been fixed in Python 2.7. I created PR 8625 to backport the fix to Python 2.7. -- nosy: +vstinner

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Ned Deily added the comment: OK, PR 1559 (in 3.7.0) for Issue30353 has been backported to 3.6 in PR 5954 for release in 3.6.5. So based on msg312200, I'm going to assume the problem is no longer reproducible in 3.6 and close this issue. If not, please reopen. --

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Vinay Sajip added the comment: > Vinay, should this back-ported to 3.6? Yes, I think it should be. -- ___ Python tracker ___

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Charalampos Stratakis added the comment: The bug is still present on the 3.6 branch. -- ___ Python tracker ___

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Ned Deily added the comment: Vinay, should this backported to 3.6? Otherwise, can the issue be closed? -- versions: +Python 3.7 ___ Python tracker

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Iryna Shcherbina added the comment: PR 1559 fixes the issue in Fedora builds on arm64. The issue is no longer reproducible with Python 3.7. -- ___ Python tracker

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Changes by Erik Bray : -- pull_requests: +1760 ___ Python tracker ___ ___

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Ned Deily added the comment: Technically speaking, we do not officially support arm64 in our release process as we have no arm64 buildbots nor an identified core developer for the platform; see PEP 11 for the policy details. So there is no place to test a fix if there was one identified.

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Changes by Vinay Sajip : -- nosy: +ned.deily ___ Python tracker ___ ___

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Vinay Sajip added the comment: I don't think it's a regression. It's catching an error that was there, but wasn't tested for before. If it should be a release blocker - that should not be for any reversion of the change to the test, but for implementing the pass-by-value functionality

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Charalampos Stratakis added the comment: Since this newly added assertion [0] fails for aarch64 shouldn't this be considered a regression? And taking into account the timeframe, a release blocker for 3.6.1? -- nosy: +cstratak ___ Python tracker

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Charalampos Stratakis added the comment: [0] https://github.com/python/cpython/commit/a86339b83fbd0932e0529a3c91935e997a234582#diff-39e8978a35ab16f78e60027c61b810f7R413 -- ___ Python tracker

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Vinay Sajip added the comment: The test checks that a structure passed by value is indeed passed by value - something that is architecture-dependent, as calling conventions differ across architectures. If the test fails, this indicates that the structure isn't being passed by value - a

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Iryna added the comment: Hi Vinay, I have added you to the nosy list as you are the author of the fix for bpo-29565, and would like to ask you for insights or ideas on why the test would fail only on one architecture (arm64)? -- ___ Python tracker

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

Changes by Iryna : -- nosy: +vinay.sajip ___ Python tracker ___ ___

[issue29804] test_ctypes test_pass_by_value fails on arm64 (aarch64) architecture

New submission from Iryna: I am trying to build Python 3.6.1rc1 on Fedora, and have the following test failing on arm64 (aarch64) architecture: == FAIL: test_pass_by_value (ctypes.test.test_structures.StructureTestCase)