[issue30028] make test.support.temp_cwd() fork-safe

Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed versions: +Python 2.7, Python 3.8 -Python 3.5 ___ Python tracker

[issue30028] make test.support.temp_cwd() fork-safe

Gregory P. Smith added the comment: New changeset 9c819a6a7d34594779fea3a25fd69ec5745e185e by Gregory P. Smith (Anselm Kruis) in branch '3.6': [3.6] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) (GH-5826)

[issue30028] make test.support.temp_cwd() fork-safe

Gregory P. Smith added the comment: New changeset 61bd4d2e6319a3c5c3b9ce5f807b44a45cc1d4a1 by Gregory P. Smith (Anselm Kruis) in branch '2.7': [2.7] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) (GH-5825)

[issue30028] make test.support.temp_cwd() fork-safe

Change by Anselm Kruis : -- pull_requests: +5604 ___ Python tracker ___ ___

[issue30028] make test.support.temp_cwd() fork-safe

Change by Anselm Kruis : -- pull_requests: +5603 ___ Python tracker ___ ___

[issue30028] make test.support.temp_cwd() fork-safe

miss-islington added the comment: New changeset 694c5e0e1f7f23595fab314f26b89e241477ff18 by Miss Islington (bot) in branch '3.7': bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066)

[issue30028] make test.support.temp_cwd() fork-safe

Change by miss-islington : -- keywords: +patch pull_requests: +5601 ___ Python tracker ___

[issue30028] make test.support.temp_cwd() fork-safe

Gregory P. Smith added the comment: New changeset 33dddac00ba8d9b72cf21b8698504077eb3c23ad by Gregory P. Smith (Anselm Kruis) in branch 'master': bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066)

[issue30028] make test.support.temp_cwd() fork-safe

Serhiy Storchaka added the comment: > os.getlogin document says `Availability: Unix, Windows.` Originally this meant "not in Mac OS, DOS, OS/2, VMS". But now the support of all these platforms is dropped and the note is outdated. -- ___ Python

[issue30028] make test.support.temp_cwd() fork-safe

INADA Naoki added the comment: > Oh. If os.getpid() is not always available, the documentation should be > updated. Yes, but CloudABI is not officially supported platform. They have many patches to run Python on CloudABI. https://github.com/NuxiNL/cloudabi-ports/tree/master/packages/python

[issue30028] make test.support.temp_cwd() fork-safe

STINNER Victor added the comment: Naoki: > #28156 added HAVE_GETPID check. > Maybe, we should have dummy getpid() for CloudABI? Oh. If os.getpid() is not always available, the documentation should be updated. -- ___ Python tracker

[issue30028] make test.support.temp_cwd() fork-safe

INADA Naoki added the comment: #28156 added HAVE_GETPID check. Maybe, we should have dummy getpid() for CloudABI? -- nosy: +inada.naoki ___ Python tracker

[issue30028] make test.support.temp_cwd() fork-safe

STINNER Victor added the comment: I proposed PR 1074 to remove the hasattr(os, 'getpid') from logging.LogRecord constructor. -- ___ Python tracker ___

[issue30028] make test.support.temp_cwd() fork-safe

Changes by STINNER Victor : -- pull_requests: +1217 ___ Python tracker ___ ___

[issue30028] make test.support.temp_cwd() fork-safe

Serhiy Storchaka added the comment: Then LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue30028] make test.support.temp_cwd() fork-safe

Anselm Kruis added the comment: I had the same concerns about os.getpid(), but test.support uses it unconditionally in various places. See https://github.com/python/cpython/blob/master/Lib/test/support/__init__.py#L803 for an example. -- ___

[issue30028] make test.support.temp_cwd() fork-safe

Christian Heimes added the comment: The line is from 2006. Some parts of the logging module are much older, maybe even from the time Python had DOS support. -- nosy: +christian.heimes ___ Python tracker

[issue30028] make test.support.temp_cwd() fork-safe

Serhiy Storchaka added the comment: Is os.getpid always available? I have found hasattr(os, 'getpid') in the logging module. -- nosy: +haypo, serhiy.storchaka, vinay.sajip stage: -> patch review ___ Python tracker

[issue30028] make test.support.temp_cwd() fork-safe

Changes by Anselm Kruis : -- pull_requests: +1212 ___ Python tracker ___ ___

[issue30028] make test.support.temp_cwd() fork-safe

New submission from Anselm Kruis: The context manager test.support.temp_cwd() creates a temporary directory and removes it on exit. The test runner test.regrtest uses this context manager. I observed an annoying behaviour of test.support.temp_cwd() on Linux/UNIX: if the code, that runs in the