[issue30121] Windows: subprocess debug assertion on failure to execute the process

miss-islington added the comment: New changeset 622a824802771fc5aa133ae92101bc8303360294 by Miss Islington (bot) in branch '3.7': bpo-30121: Fix test_subprocess for Windows Debug builds (GH-5758)

[issue30121] Windows: subprocess debug assertion on failure to execute the process

miss-islington added the comment: New changeset ef0bb5c7b76a49a5f3c5b85b5f9112cfefe54328 by Miss Islington (bot) in branch '3.6': bpo-30121: Fix test_subprocess for Windows Debug builds (GH-5758)

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Change by miss-islington : -- pull_requests: +5537 ___ Python tracker ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Change by miss-islington : -- pull_requests: +5538 ___ Python tracker ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Zachary Ware added the comment: New changeset 5537646bfacec463b450871dde31cb06c44a0556 by Zachary Ware in branch 'master': bpo-30121: Fix test_subprocess for Windows Debug builds (GH-5758)

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Change by Zachary Ware : -- pull_requests: +5536 ___ Python tracker ___ ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

STINNER Victor added the comment: > Oops, I merged the pull requests, but I forgot to close the issue. Oops, I forgot to close the issue, again... Thanks Segev for closing it, finally :-) -- ___ Python tracker

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Change by Segev Finer : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

STINNER Victor added the comment: Oops, I merged the pull requests, but I forgot to close the issue. -- ___ Python tracker

[issue30121] Windows: subprocess debug assertion on failure to execute the process

STINNER Victor added the comment: Python 2.7 doesn't seem to be affected by this issue. Extract of Popen.__init__: try: self._execute_child(args, executable, preexec_fn, close_fds, cwd, env, universal_newlines,

[issue30121] Windows: subprocess debug assertion on failure to execute the process

STINNER Victor added the comment: New changeset e76cb435563cd14bb085942dfefbb469b8f40aa9 by Victor Stinner in branch '3.6': [3.6] bpo-30121: Fix debug assert in subprocess on Windows (#1224) (#3173) https://github.com/python/cpython/commit/e76cb435563cd14bb085942dfefbb469b8f40aa9 --

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Changes by STINNER Victor : -- pull_requests: +3209 ___ Python tracker ___ ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

STINNER Victor added the comment: New changeset 9a83f651f31b47b3f6c8b210f7807b26e8c373a5 by Victor Stinner in branch 'master': Add test_subprocess.test_nonexisting_with_pipes() (#3133) https://github.com/python/cpython/commit/9a83f651f31b47b3f6c8b210f7807b26e8c373a5 --

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Changes by STINNER Victor : -- pull_requests: +3167 ___ Python tracker ___ ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

STINNER Victor added the comment: New changeset 4d3851727fb82195e4995c6064b0b2d6cbc031c4 by Victor Stinner (Segev Finer) in branch 'master': bpo-30121: Fix debug assert in subprocess on Windows (#1224) https://github.com/python/cpython/commit/4d3851727fb82195e4995c6064b0b2d6cbc031c4

[issue30121] Windows: subprocess debug assertion on failure to execute the process

STINNER Victor added the comment: See https://github.com/python/cpython/pull/1224 and http://bugs.python.org/issue30121 -- ___ Python tracker ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Terry J. Reedy added the comment: I determined in #31228 (also on Windows, closed as a duplicate) that a debug build, bad file, and subprocess.PIPE are all required. Has this been tried on non-Windows? I confirmed the crash on 3.6. I do not have a 2.7 repository build. The two lines above

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

Changes by Segev Finer : -- pull_requests: +1346 ___ Python tracker ___ ___

[issue30121] Windows: subprocess debug assertion on failure to execute the process

New submission from Segev Finer: subprocess triggers a debug assertion in the CRT on failure to execute the process due to closing the pipe *handles* in the except clause using os.close rather than .Close() (os.close closes CRT file descriptors and not handles). In addition to that once this