Roundup Robot added the comment:
New changeset 3d8109fe6d82 by Gregory P. Smith in branch 'default':
Correct a comment in the test referencing the wrong issue number (issue3100
https://hg.python.org/cpython/rev/3d8109fe6d82
--
nosy: +python-dev
___
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
This was fixed 4 months ago with r64309 (trunk, 2.6) and r64310 (2.5).
--
resolution: - fixed
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
Committed r64309, with the suggested whitespace change.
Will backport.
Concerning the INCREF patch: would a simple assert(refcnt0) be enough?
___
Python tracker [EMAIL PROTECTED]
Adam Olsen [EMAIL PROTECTED] added the comment:
Unfortunately, Py_INCREF is sometimes used in an expression (followed by
a comma). I wouldn't expect an assert to be valid there (and I'd want
to check ISO C to make sure it's portable, not just accepted by GCC).
I'd like if Py_INCREF and friends
Changes by Jesse Noller [EMAIL PROTECTED]:
--
nosy: +roudkerk
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
___
___
Python-bugs-list mailing list
Adam Olsen [EMAIL PROTECTED] added the comment:
Patch to add extra sanity checks to Py_INCREF (only if Py_DEBUG is set).
If the refcount is 0 or negative if calls Py_FatalError. This should
catch revival bugs such as this one a little more clearly.
The patch also adds a little more checking
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
All the versions I tried (2.4, 2.5, 2.6, 3.0) crash with the given script
--
components: +Interpreter Core -Extension Modules
nosy: +amaury.forgeotdarc
versions: +Python 2.5
___
Python tracker
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
It seems enough to simply skip deleted weakrefs in PyObject_ClearWeakRefs.
Here is a tentative patch.
Added file: http://bugs.python.org/file10615/weakref_cycle.patch
___
Python tracker [EMAIL
Changes by Amaury Forgeot d'Arc [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file10615/weakref_cycle.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
___
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
A new version of the patch, which tests the case of multiple weakrefs on
the same object, that get deleted together:
tp_dealloc of one weakref calls tp_dealloc of the second weakref, which
calls tp_dealloc of the referenced object. Since
Changes by Adam Olsen [EMAIL PROTECTED]:
--
nosy: +jnoller
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
___
___
Python-bugs-list mailing list
Adam Olsen [EMAIL PROTECTED] added the comment:
Well, my attempt at a patch didn't work, and yours does, so I guess I
have to support yours. ;)
Can you review my python-incref-from-zero patch? It verifies the
invariant that you need, that once an object hits a refcount of 0 it
won't get raised
Adam Olsen [EMAIL PROTECTED] added the comment:
Ahh, it seems gcmodule already considers the weakref to be reachable
when it calls the callbacks, so it shouldn't be a problem.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
Changes by Amaury Forgeot d'Arc [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file10616/weakref_cycle.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
___
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
you're asserting cbcalled, but you're not using the generic callback,
so it's meaningless.
The new patch corrects this
Added file: http://bugs.python.org/file10625/weakref_cycle.patch
___
Python
Adam Olsen [EMAIL PROTECTED] added the comment:
Another minor nit: if(current-ob_refcnt 0) should have a space
after the if. Otherwise it's looking good.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
Changes by Benjamin Peterson [EMAIL PROTECTED]:
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
___
___
Python-bugs-list mailing list
Unsubscribe:
Adam Olsen [EMAIL PROTECTED] added the comment:
Specific enough yet? Seems the WeakValueDictionary and the module
clearing aren't necessary.
A subclass of weakref is created. The target of this weakref is added
as an attribute of the weakref. So long as a callback is present there
will be a
Changes by Adam Olsen [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file10612/inner.py
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
___
___
Changes by Adam Olsen [EMAIL PROTECTED]:
Removed file: http://bugs.python.org/file10611/outer.py
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3100
___
___
Adam Olsen [EMAIL PROTECTED] added the comment:
1. MyRef is released from the module as part of shutdown
2. MyRef's subtype_dealloc DECREFs its dictptr (not clearing it, as
MyRef is dead and should be unreachable)
3. the dict DECREFs the Dummy (MyRef's target)
4. Dummy's subtype_dealloc calls
Adam Olsen [EMAIL PROTECTED] added the comment:
Ahh, I missed a detail: when the callback is called the weakref has a
refcount of 0, which is ICNREFed to 1 when getting put in the args, then
drops down to 0 again when the args are DECREFed (causing it to get
_Py_ForgetReference to be called a
22 matches
Mail list logo
