[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Steve Dower added the comment: Closing this as we've resolved it elsewhere. Thanks for the contribution! -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Steve Dower added the comment: I think this definitely conflicts with the behaviour we've been working on for the last week over on issue37834 (the PR is going to conflict for sure). I am making a change to rmtree() that will cause it to delete junction point without trying to recursively

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Eryk Sun added the comment: > Thanks for the detailed explanation Eryk. While it is a little > annoying that it comes 2 years after the initial proposed > solution, I'll happily take that if the end result is a better fix :) Mea culpa. I am sorry about that. I do respect your time and the

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Vidar Fauske added the comment: Thanks for the detailed explanation Eryk. While it is a little annoying that it comes 2 years after the initial proposed solution, I'll happily take that if the end result is a better fix :) That being said, this fix seems quite a bit more involved to

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Eryk Sun added the comment: > Junctions are sometimes used as links (e.g. mklink /j) and sometimes > as volume mount points (e.g. mountvol.exe). That people sometimes use junctions as if they're symlinks doesn't mean that we should pretend it's true. The reparse tag is

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Steve Dower added the comment: Sorry for being slow to review, I just added a few more comments on the PR and I think we're nearly done. -- versions: +Python 3.9 -Python 3.6 ___ Python tracker

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Vidar Fauske added the comment: I think the submitted PR could need a pair of eyes now. I've sorted the merge conflicts, and addressed the previous review points by eryksun. -- ___ Python tracker

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Change by Terry J. Reedy : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Vidar Fauske added the comment: A PR that fixes the issue according to the feedback from Eryk Sun is available. It does seem to have stranded a bit on the review side. That being said, would a bugfix for shutil.rmtree be appropriate? It is very annoying when junction

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Change by Vidar Fauske : -- keywords: +patch pull_requests: +5764 stage: test needed -> patch review ___ Python tracker ___

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Changes by Eryk Sun : -- components: -IO stage: -> test needed type: -> behavior versions: +Python 3.7 -Python 3.3 ___ Python tracker

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

Eryk Sun added the comment: Junctions are sometimes used as links (e.g. mklink /j) and sometimes as volume mount points (e.g. mountvol.exe). GetVolumePathName can be called to distinguish these cases. If a junction is a volume mount point, then its absolute path and volume path are the same.

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

New submission from Vidar Fauske: On Windows (Windows 10 in my case), given the following directory structure: - rootfolder - a - b - junc (directory junction to ../a) a call to `shutil.rmtree('root')` will fail with an exception `FileNotFoundError: [WinError 3]`, in a call to