[issue31512] Add non-elevated symlink support for dev mode Windows 10

Steve Dower added the comment: Done -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Steve Dower added the comment: New changeset 0e10766574f4e287cd6b5e5860a1ca75488f4119 by Steve Dower (Vidar Tonaas Fauske) in branch 'master': bpo-31512: Add non-elevated symlink support for Windows (GH-3652) https://github.com/python/cpython/commit/0e10766574f4e287cd6b5e5860a1ca75488f4119

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Eryk Sun added the comment: :ping: It seems this was ready to be merged a while ago. -- ___ Python tracker ___ ___

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Vidar Fauske added the comment: Thanks! I addressed the comment, so hopefully this should be OK now. -- ___ Python tracker ___ ___

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Steve Dower added the comment: Thanks for the ping (I don't see GitHub notifications - I get 1000s per day and it's not feasible to read them). I left one more comment on the PR, but then it's good to go! -- ___ Python tracker

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Vidar Fauske added the comment: The PR has been sitting for a while now with all previous concerns addressed. There has been a few pings on the PR without anything new happening, so I thought I would ping this issue as well: are there any other concerns about this PR, or anything else that

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Change by Terry J. Reedy : -- versions: +Python 3.8 -Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Change by Alexey Izbyshev : -- nosy: +izbyshev ___ Python tracker ___ ___

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Vidar Fauske added the comment: Thanks for the informative comments. I opened a PR based on this feedback. Would you mind checking if it conforms to what you had in mind? -- ___ Python tracker

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Changes by Vidar Fauske : -- pull_requests: +3645 stage: -> patch review ___ Python tracker ___

[issue31512] Add non-elevated symlink support for dev mode Windows 10

Eryk Sun added the comment: Py_CreateSymbolicLinkW can be removed in 3.5+ because Windows XP is no longer supported and calling enable_symlink() is pointless. The Windows API uses some privileges simply to determine which security principals can access a capability. Whether the privilege is

[issue31512] Add non-elevated symlink support for dev mode Windows 10

New submission from Vidar Fauske: As explained in this Microsoft blogpost (https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/), it is possible on newer versions of Windows 10 for non-privileged users to create symlinks when the machine is in developer mode. However, to