[issue31823] Opaque default value for close_fds argument in Popen.__init__

Martin Panter added the comment: The only problem with the 3.7+ documentation is the note about 3.2. Several paragraphs under , it still says “Changed in version 3.2: The default for ‘close_fds’ was changed from

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Gregory P. Smith added the comment: Only if someone can point to a concrete problem to be fixed in the 3.7+ docs. Looking at all references to close_fds in https://docs.python.org/3/library/subprocess.html I don't see one. (I'm not going to touch the 3.6 docs) --

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Tal Einat added the comment: Gregory, this issue was about the docs, not the doc-string (help()). Are you sure it should be closed? -- ___ Python tracker ___

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Gregory P. Smith added the comment: In 3.6 this help(subprocess.Popen.__init__) is accurate and encourages looking at the docs. In 3.7 and later it'll simply report close_fds=True in the siguature as that is the case in 3.7 onwards. I see nothing to fix here. -- nosy:

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Change by Gregory P. Smith : -- versions: -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Change by Danish Prakash : -- keywords: +patch pull_requests: +10276 stage: -> patch review ___ Python tracker ___ ___

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Tal Einat added the comment: Danish, see Martin's previous comment (msg314413): "... the signature at [the 3.6 docs] should not show close_fds=True, because that is not necessarily the default on Windows." -- ___ Python tracker

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Danish Prakash added the comment: I'd like to work on this. I get that the 3.7+ doc still has the irrelevant change from 3.6 which needs to be removed but I'm not sure what's wrong with the 3.6 doc. > The signature is indeed awkward for 3.6, -- nosy: +danishprakash

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Tal Einat added the comment: ISTM that the docs need to be fixed for both 3.7+ and for 3.6. The signature is indeed awkward for 3.6, but it's too minor a detail to address considering it's no longer relevant for 3.7 and later. -- assignee: -> docs@python components: +Documentation

[issue31823] Opaque default value for close_fds argument in Popen.__init__

Martin Panter added the comment: The close_fds= in that signature seems fine to me. If you read the documentation, it says the default mode depends on the platform, and on other parameters. However I think the signature at

[issue31823] Opaque default value for close_fds argument in Popen.__init__

New submission from Алексей Аверченко : [11:30:03 ~]$ python Python 3.6.1 |Anaconda 4.4.0 (x86_64)| (default, May 11 2017, 13:04:09) [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>>