[issue31844] HTMLParser: undocumented not implemented method

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31844] HTMLParser: undocumented not implemented method

Berker Peksag added the comment: New changeset d4d127f1c6e586036104e4101f5af239fe7dc156 by Berker Peksag in branch 'master': bpo-31844: Move whatsnew note to 3.10.rst (GH-21504) https://github.com/python/cpython/commit/d4d127f1c6e586036104e4101f5af239fe7dc156 --

[issue31844] HTMLParser: undocumented not implemented method

Change by Berker Peksag : -- pull_requests: +20644 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/21504 ___ Python tracker ___

[issue31844] HTMLParser: undocumented not implemented method

Berker Peksag added the comment: New changeset e34bbfd61f405eef89e8aa50672b0b25022de320 by Berker Peksag in branch 'master': bpo-31844: Remove _markupbase.ParserBase.error() (GH-8562) https://github.com/python/cpython/commit/e34bbfd61f405eef89e8aa50672b0b25022de320 --

[issue31844] HTMLParser: undocumented not implemented method

Cheryl Sabella added the comment: @berker.peksag's last comment was he closed the PR on 23 August 2018. However, he reopened it on 6 January 2020 as @ezio.melotti mentioned that they are both needed. The PR for this issue is waiting to be re-reviewed by Ezio. -- nosy:

[issue31844] HTMLParser: undocumented not implemented method

Change by Ezio Melotti : -- assignee: -> ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31844] HTMLParser: undocumented not implemented method

Change by Berker Peksag : -- stage: patch review -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue31844] HTMLParser: undocumented not implemented method

Berker Peksag added the comment: After triaging issue 34480, I realized that we can't simply remove the error() method because the _markupbase.ParserBase() class still uses it. I've just closed PR 8562. -- ___ Python tracker

[issue31844] HTMLParser: undocumented not implemented method

Sebastian Rittau added the comment: Good call. Maybe it's actually time to retire _markupbase and merge ParserBase into HTMLParser. -- ___ Python tracker ___

[issue31844] HTMLParser: undocumented not implemented method

Change by Berker Peksag : -- keywords: +patch pull_requests: +8076 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue31844] HTMLParser: undocumented not implemented method

Berker Peksag added the comment: HTMLParser.error() method was deprecated in Python 3.4 (https://github.com/python/cpython/commit/88ebfb129b59dc8a2b855fc93fcf32457128d64d#diff-1a7486df8279dbac7f20abd487947845R157) and removed in Python 3.5

[issue31844] HTMLParser: undocumented not implemented method

Change by Serhiy Storchaka : -- components: +Library (Lib) nosy: +ezio.melotti type: -> behavior ___ Python tracker ___

[issue31844] HTMLParser: undocumented not implemented method

William Ayd added the comment: And assuming that subclass requirement is intentional we could add an optional keyword argument to the HTMLParser that indicates what to do with errors, much like how encoding issues are handled within codecs. For backwards compatibility

[issue31844] HTMLParser: undocumented not implemented method

William Ayd added the comment: Would we be open to setting the meta class of the ParserBase to ABCMeta and setting error as an abstract method? That at the very least would make the expectation clearer for subclasses. I haven’t contributed to Python before but am open

[issue31844] HTMLParser: undocumented not implemented method

Sebastian Rittau added the comment: The quoted code above should have used ParserBase: class ParserBase: ... def error(self, message): raise NotImplementedError( "subclasses of ParserBase must override error()") --

[issue31844] HTMLParser: undocumented not implemented method

New submission from Sebastian Rittau : HTMLParser derives from _markupbase.ParserBase, which has the following method: class HTMLParser: ... def error(self, message): raise NotImplementedError( "subclasses of ParserBase must override error()")