[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: Fixed by PR 4349 (changeset 15e14538f90cabc87473a489316fdb81af76cfb2). -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31893] Issues with kqueue

Change by Serhiy Storchaka : -- pull_requests: +4306 stage: resolved -> patch review ___ Python tracker ___

[issue31893] Issues with kqueue

STINNER Victor added the comment: I suggest to fix the tests, the code looks good to me. -- ___ Python tracker ___

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: Because the default behavior is different in Python 2 and Python 3. In Python 3 this is a TypeError. In Python 2 all objects are comparable by default. -- ___ Python tracker

[issue31893] Issues with kqueue

STINNER Victor added the comment: kqueue_event_richcompare() returns NotImplemented if other is not an event: if (!kqueue_event_Check(o)) { Py_INCREF(Py_NotImplemented); return Py_NotImplemented; } So I don't understand why tests started to

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: Oh, I didn't test on 2.7. The old code contradicted the common comparison behavior. It allowed comparing select.kevent with other objects only for equality as for identity. `kevent == other` always returned False even if `other

[issue31893] Issues with kqueue

STINNER Victor added the comment: Same failure on x86-64 El Capitan 2.7/ http://buildbot.python.org/all/#builders/98/builds/17 == FAIL: test_create_event (test.test_kqueue.TestKQueue)

[issue31893] Issues with kqueue

STINNER Victor added the comment: On also AMD64 FreeBSD 10.x Shared 2.7: http://buildbot.python.org/all/#/builders/97/builds/17 == FAIL: test_create_event (test.test_kqueue.TestKQueue)

[issue31893] Issues with kqueue

STINNER Victor added the comment: Test fails on x86 Tiger 2.7: http://buildbot.python.org/all/#/builders/59/builds/17 == FAIL: test_create_event (test.test_kqueue.TestKQueue)

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: New changeset ce51890894be46f8f9d991a1d0ea1455fc41ccdc by Serhiy Storchaka in branch '2.7': bpo-31893: Fix a backporting error in 8cbf4e10646c3f5b8f0d274c2d7dea5bb6305f57. (#4219)

[issue31893] Issues with kqueue

Change by Serhiy Storchaka : -- pull_requests: +4187 ___ Python tracker ___ ___

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: Tests on all buildbots are passed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: New changeset 84e252b79eed94bc9e9175f82191322c89e489ad by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-31893: Fix errors in b9052a0f91d2e83bbc27267247a5920c82b242a3. (GH-4196) (#4201)

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: New changeset e7531e54bf195b8d3ed35b4138901c82f7ed794c by Serhiy Storchaka (Miss Islington (bot)) in branch '2.7': bpo-31893: Fix errors in b9052a0f91d2e83bbc27267247a5920c82b242a3. (GH-4196) (#4202)

[issue31893] Issues with kqueue

Change by Roundup Robot : -- pull_requests: +4171 ___ Python tracker ___

[issue31893] Issues with kqueue

Change by Roundup Robot : -- pull_requests: +4169 ___ Python tracker ___

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: New changeset 2298fad5ff907dd48ea0fb5c71fa22334ef28c6b by Serhiy Storchaka in branch 'master': bpo-31893: Fix errors in b9052a0f91d2e83bbc27267247a5920c82b242a3. (#4196)

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: Oh, I forgot that Mac OS X also in the BSD family. Thank you Victor for signaling errors. -- ___ Python tracker

[issue31893] Issues with kqueue

Change by Serhiy Storchaka : -- pull_requests: +4166 ___ Python tracker ___ ___

[issue31893] Issues with kqueue

STINNER Victor added the comment: Oh, the commit also broke the "x86 Tiger 3.x buildbot: http://buildbot.python.org/all/#/builders/30/builds/93 == FAIL: test_create_event

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: New changeset 8cbf4e10646c3f5b8f0d274c2d7dea5bb6305f57 by Serhiy Storchaka in branch '2.7': [2.7] bpo-31893: Fixed select.kqueue(). (GH-4166) (#4193)

[issue31893] Issues with kqueue

STINNER Victor added the comment: The commit b9052a0f91d2e83bbc27267247a5920c82b242a3 broke compilation on FreeBSD: building 'select' extension cc -pthread -fPIC -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes -std=c99 -Wextra -Wno-unused-result

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: New changeset f9a639b97c760f40d03c7655053c89752850 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-31893: Fixed select.kqueue(). (GH-4166) (#4190)

[issue31893] Issues with kqueue

Change by Serhiy Storchaka : -- pull_requests: +4163 ___ Python tracker ___ ___

[issue31893] Issues with kqueue

Change by Roundup Robot : -- pull_requests: +4160 ___ Python tracker ___

[issue31893] Issues with kqueue

Serhiy Storchaka added the comment: New changeset b9052a0f91d2e83bbc27267247a5920c82b242a3 by Serhiy Storchaka in branch 'master': bpo-31893: Fixed select.kqueue(). (#4166) https://github.com/python/cpython/commit/b9052a0f91d2e83bbc27267247a5920c82b242a3

[issue31893] Issues with kqueue

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4135 stage: -> patch review ___ Python tracker ___

[issue31893] Issues with kqueue

New submission from Serhiy Storchaka : In Modules/selectmodule.c it is assumed that the kevent structure is defined on FreeBSD and NetBSD as: struct kevent { uintptr_t ident; short filter; u_short flags;