[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

miss-islington added the comment: New changeset af009fbcdb00fffced653792eb7af6b72f2521e3 by Miss Islington (bot) in branch '3.6': bpo-32035: Fix words about strings and bytes in zipfile documentation. (GH-10592)

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

miss-islington added the comment: New changeset 89a3087d40feed3ca78033319389437bb4b5bcd7 by Miss Islington (bot) in branch '3.7': bpo-32035: Fix words about strings and bytes in zipfile documentation. (GH-10592)

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Change by miss-islington : -- pull_requests: +9948 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Change by miss-islington : -- pull_requests: +9947 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Serhiy Storchaka added the comment: New changeset 4bb186d7e253ad4def875305e06690181e923dfd by Serhiy Storchaka in branch 'master': bpo-32035: Fix words about strings and bytes in zipfile documentation. (GH-10592)

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Serhiy Storchaka added the comment: Since the docstring contains more information, it is better to just copy words from the docstring to the documentation. There are also other places where string is improperly used instead of bytes or the type is not specified. The note about file name

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Change by Serhiy Storchaka : -- pull_requests: +9838 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Sanyam Khurana added the comment: The change in current PR is very minor and looks good enough that aligns the docs with the docstring and functionality of `ZipFile.writestr` as described. Can a core-contributor, please look at this? Also, I'm adding 3.8 for this change. -- nosy:

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Change by Chirag Rathod : -- pull_requests: +4660 ___ Python tracker ___ ___

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Change by Chirag Rathod : -- keywords: +patch pull_requests: +4610 stage: needs patch -> patch review ___ Python tracker ___

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

Change by Serhiy Storchaka : -- keywords: +easy stage: -> needs patch type: -> enhancement versions: -Python 3.4, Python 3.5, Python 3.8 ___ Python tracker

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

New submission from Daniel : The documentation for "ZipFile.writestr(zinfo_or_arcname, data[, compress_type])" says: "Write the string data to the archive; [...]" --> https://docs.python.org/3/library/zipfile.html I fails to mention that data could also be bytes. The