[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Irit Katriel added the comment: I think this is resolved and can be closed. -- nosy: +iritkatriel ___ Python tracker ___ ___

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

miss-islington added the comment: New changeset 51d95ffc2fb3337dc87277c9af25ecc9a01f991b by Miss Islington (bot) in branch '3.7': bpo-3: Fix pygettext skipping docstrings for funcs with arg typehints (GH-4745)

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Change by miss-islington : -- pull_requests: +5687 ___ Python tracker ___

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Change by miss-islington : -- pull_requests: +5686 ___ Python tracker ___

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Serhiy Storchaka added the comment: New changeset eee72d4778a5513038edd5236cdd87ccce2bc60a by Serhiy Storchaka (Tobotimus) in branch 'master': bpo-3: Fix pygettext skipping docstrings for funcs with arg typehints (GH-4745)

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka versions: +Python 3.7 -Python 3.5 ___ Python tracker

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Change by Toby Harradine : -- keywords: +patch pull_requests: +4648 stage: -> patch review ___ Python tracker ___

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Toby Harradine added the comment: Another correction; I said that this is occurring for return type annotations; this is not true. This is only occurring for functions with annotated *arguments*. The cause of this issue is in pygettext's TokenEater.__suiteseen

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Toby Harradine added the comment: Correction for above: the type annotation syntax is actually from PEP 3107, not PEP 484. I should also point out that this behaviour is occurring for annotated return types of functions and methods as well. This is occurring on both

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

Change by Toby Harradine : Added file: https://bugs.python.org/file47317/pygettext_output.pot ___ Python tracker ___

[issue32222] pygettext doesn't extract docstrings for functions with type annotated params

New submission from Toby Harradine : ### Expected Behaviour When running pygettext with the -D CLI flag, all module, class, method and function docstrings should be extracted and outputted to the .pot file. ### Actual Behaviour In the case of functions whose parameters