[issue32227] singledispatch support for type annotations

Change by Łukasz Langa : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32227] singledispatch support for type annotations

Change by Xiang Zhang : -- pull_requests: +5882 stage: -> patch review ___ Python tracker ___

[issue32227] singledispatch support for type annotations

Ivan Levkivskyi added the comment: > Do you think it should be added to the What's New? page for 3.7? I leave this up to Łukasz. -- ___ Python tracker

[issue32227] singledispatch support for type annotations

Cheryl Sabella added the comment: Hello, I believe this could be closed as resolved? Do you think it should be added to the What's New? page for 3.7? -- nosy: +csabella ___ Python tracker

[issue32227] singledispatch support for type annotations

Łukasz Langa added the comment: New changeset e56975351bc2c574c728f738e88effba7116279f by Łukasz Langa in branch 'master': bpo-32227: functools.singledispatch supports registering via type annotations (#4733)

[issue32227] singledispatch support for type annotations

Łukasz Langa added the comment: > this creates a circular dependency functools <-> typing Well, it doesn't since I explicitly import typing inside singledispatch. By the time this import happens, functools is fully imported. This would only be a problem if functools itself

[issue32227] singledispatch support for type annotations

Ivan Levkivskyi added the comment: Idea looks interesting (like a basic runtime @overload). My expectation is that some changes are necessary in mypy for this to work properly. Another (minor) problem is that this creates a circular dependency functools <-> typing.

[issue32227] singledispatch support for type annotations

Ivan Levkivskyi added the comment: Oops something wrong happened. -- nosy: +gvanrossum stage: patch review -> ___ Python tracker

[issue32227] singledispatch support for type annotations

Łukasz Langa added the comment: Guido, I know that you have a lot on your plate right now. Adding you because of PEP 443 and PEP 484. -- nosy: +gvanrossum stage: patch review -> ___ Python tracker

[issue32227] singledispatch support for type annotations

Change by Łukasz Langa : -- keywords: +patch pull_requests: +4636 stage: -> patch review ___ Python tracker ___

[issue32227] singledispatch support for type annotations

New submission from Łukasz Langa : With the patch attached to this issue, @singledispatch gains support for passing the type in @register via annotations. This looks more natural and enables more thorough type checking without repeating yourself: @singledispatch def