[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-14 Thread STINNER Victor
STINNER Victor added the comment: It seems like AppVeyor is fixed, thanks Steve for the help! Later, it would be nice to write a more generic fix than hardcoding two minor versions. -- resolution: -> fixed stage: patch review -> resolved status: open ->

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 645fa19f15cddeec8d882a9e1420173e7516f0e4 by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-32302: Fix distutils bdist_wininst for CRT v142 (GH-4851) (#4861)

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-14 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4751 ___ Python tracker ___

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9e7c136ad8bc8e8eec50c2a8ae5ff02752f695a2 by Victor Stinner in branch 'master': bpo-32302: Fix distutils bdist_wininst for CRT v142 (#4851)

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread STINNER Victor
STINNER Victor added the comment: > Happy for someone else to do it. I won't have time this week - too much going > on at work. Sure. I wrote a PR to fix the exact bug. -- ___ Python tracker

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +4740 stage: needs patch -> patch review ___ Python tracker ___

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread Steve Dower
Steve Dower added the comment: Happy for someone else to do it. I won't have time this week - too much going on at work. -- ___ Python tracker

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread STINNER Victor
STINNER Victor added the comment: @Steve: do you want to work on a fix? -- ___ Python tracker ___

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread Steve Dower
Steve Dower added the comment: This is the bit that needs fixing https://github.com/python/cpython/blob/master/Lib/distutils/command/bdist_wininst.py#L340 bv = '.'.join(CRT_ASSEMBLY_VERSION.split('.', 2)[:2]) if bv == '14.11':

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread STINNER Victor
STINNER Victor added the comment: Oh, and the PATH: os.environ[PATH]: C:\Perl\site\bin;C:\Perl\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread STINNER Victor
STINNER Victor added the comment: Extract of pythoninfo of the failed build: os.environ[VS110COMNTOOLS]: C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\Tools\ os.environ[VS120COMNTOOLS]: C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\Tools\

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread Steve Dower
Steve Dower added the comment: I thought we'd special cased the v14 toolset already. This should be an update to the Python code in distutils that selects the filename based on compiler version. -- ___ Python tracker

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread Zachary Ware
Change by Zachary Ware : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware priority: normal -> high stage: -> needs patch ___ Python tracker

[issue32302] test_distutils: test_get_exe_bytes() failure on AppVeyor

2017-12-13 Thread STINNER Victor
New submission from STINNER Victor : Example: https://ci.appveyor.com/project/python/cpython/build/3.7.0a0.9414 == ERROR: test_get_exe_bytes (distutils.tests.test_bdist_wininst.BuildWinInstTestCase)