[issue32318] Remove "globals()" call from "socket.accept()"

2017-12-20 Thread Yury Selivanov
Yury Selivanov added the comment: This was fixed as part of https://bugs.python.org/issue32331 -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32318] Remove "globals()" call from "socket.accept()"

2017-12-13 Thread STINNER Victor
STINNER Victor added the comment: IMHO we should add a private mask constant, see: https://github.com/python/cpython/pull/4231#issuecomment-351622381 -- ___ Python tracker

[issue32318] Remove "globals()" call from "socket.accept()"

2017-12-13 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +4746 stage: -> patch review ___ Python tracker ___

[issue32318] Remove "globals()" call from "socket.accept()"

2017-12-13 Thread Yury Selivanov
New submission from Yury Selivanov : socket.accept currently has this code: type = self.type & ~globals().get("SOCK_NONBLOCK", 0) which I believe is (a) bad Python style; (b) slows things down. -- components: +Library (Lib) nosy: +asvetlov, vstinner type: ->

[issue32318] Remove "globals()" call from "socket.accept()"

2017-12-13 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: yselivanov priority: normal severity: normal status: open title: Remove "globals()" call from "socket.accept()" ___ Python tracker