[issue32337] Dict order is now guaranteed, so add tests and doc for it

Ned Deily added the comment: Thanks for doing this! Let's close it. If comments arise prior to its release in 370b4, we can reopen, otherwise please open a new issue. -- priority: deferred blocker -> resolution: -> fixed stage: patch review -> resolved status:

[issue32337] Dict order is now guaranteed, so add tests and doc for it

INADA Naoki added the comment: Any other known issue? May I close this issue? -- ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

miss-islington added the comment: New changeset 9216dffbc8a2aa62789f81f51f64bc1ec7bf6883 by Miss Islington (bot) in branch '3.7': bpo-32337: Update documentats about dict order (GH-4973)

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Change by miss-islington : -- pull_requests: +6079 ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

INADA Naoki added the comment: New changeset dfbbbf16f9aab82330c634913441b5ac73267d9c by INADA Naoki (hui shang) in branch 'master': bpo-32337: Update documentats about dict order (GH-4973)

[issue32337] Dict order is now guaranteed, so add tests and doc for it

INADA Naoki added the comment: > I started to add this comment to #33218 but Raymond closed that ticket while > I was editing it. Sorry, I closed it, not Raymond. -- ___ Python tracker

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Steven D'Aprano added the comment: I started to add this comment to #33218 but Raymond closed that ticket while I was editing it. In 3.6, dicts preserving insertion order remains an implementation detail that cannot be relied on. It only becomes a guarantee in

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Ned Deily added the comment: Raymond, do you want to review the current state of the PR before 3.7.0b4? Otherwise, I'll probably ask that it be merged as is. -- priority: release blocker -> deferred blocker ___ Python tracker

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Change by Serhiy Storchaka : -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Change by Raymond Hettinger : -- assignee: rhettinger -> ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

shangdahao added the comment: Thanks zhang, I have updated it in the PR. -- ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Xiang Zhang added the comment: This part needs editing too, the text and example. https://docs.python.org/3/library/stdtypes.html#dictionary-view-objects -- nosy: +xiang.zhang ___ Python tracker

[issue32337] Dict order is now guaranteed, so add tests and doc for it

shangdahao added the comment: Thanks inada, I removed the tests from the PR. -- nosy: +shangdahao ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

New submission from INADA Naoki : FYI, Builtin dict is tested for ordering already: https://github.com/python/cpython/blob/13a6c098c215921e35004f9d3a9b70f601e56500/Lib/test/test_ordered_dict.py#L646-L662 -- nosy: +inada.naoki

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Change by shangdahao : -- keywords: +patch pull_requests: +4864 stage: needs patch -> patch review ___ Python tracker ___

[issue32337] Dict order is now guaranteed, so add tests and doc for it

Change by Raymond Hettinger : -- title: Dict order is now guaranteed, so add tests for it -> Dict order is now guaranteed, so add tests and doc for it ___ Python tracker