[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

Change by Alexey Izbyshev : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

Gregory P. Smith added the comment: New changeset 2d8f06382e7d5a759ca554110a699a397114824a by Gregory P. Smith (izbyshev) in branch 'master': bpo-32369: test_subprocess: Fix pass_fds check in test_close_fds() (#4920)

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

Change by Alexey Izbyshev : -- keywords: +patch pull_requests: +4815 stage: -> patch review ___ Python tracker ___

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

Change by Alexey Izbyshev : -- nosy: +gregory.p.smith, pitrou ___ Python tracker ___ ___

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

New submission from Alexey Izbyshev : The last part of test_close_fds() doesn't match its own comment. The following assertion always holds because fds_to_keep and open_fds are disjoint by construction. self.assertFalse(remaining_fds & fds_to_keep & open_fds,