[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Change by Stefan Behnel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Stefan Behnel added the comment: New changeset 7d952ded6813c896ea3f4234bb8db5247dcb5484 by Stefan Behnel (Gordon P. Hemsley) in branch 'master': bpo-32424: Deprecate xml.etree.ElementTree.Element.copy() in favor of copy.copy() (GH-12995)

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Stefan Behnel added the comment: Let's just deprecate it directly (in Py3.9, I guess), given that it was never documented. -- ___ Python tracker ___

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Gordon P. Hemsley added the comment: It seems the final open question on this is whether the mismatch between the Python and C implementations is enough to bypass PendingDeprecationWarning for copy() in favor of jumping straight to DeprecationWarning. --

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Change by Gordon P. Hemsley : -- pull_requests: +12918 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Stefan Behnel added the comment: New changeset 50fed0b64faa305338ef5607b570fe209de6 by Stefan Behnel (Gordon P. Hemsley) in branch 'master': bpo-32424: Improve test coverage for xml.etree.ElementTree (GH-12891)

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Change by Gordon P. Hemsley : -- pull_requests: +12822 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Serhiy Storchaka added the comment: Concur with Stefan. Adding the method deprecated from the born looks silly. We should either deprecate the copy() method in the Python implementation, or add an undeprecated method in the C implementation. The latter should be considered as a new feature.

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Stefan Behnel added the comment: We should not add anything to the implementation that we consider legacy elsewhere. Py3 has "always" used the C accelerator module instead of the Python implementation, which suggests that its interface is probably the righter one. So: make sure that the

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Gordon P. Hemsley added the comment: Opened issue36685 for discussion of the attrib copy issue. -- ___ Python tracker ___ ___

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Gordon P. Hemsley added the comment: Taking a step back, I want to make sure I understand the action items for resolving this: * Add copy() as an alias to __copy__() in the C implementation to match the Python implementation. * Deprecate copy() in favor of copy.copy() in both the Python and

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Serhiy Storchaka added the comment: > As it stands, calling Element.__deepcopy__() will succeed with the C > implementation and fail with the Python implementation. You should not call it directly. Use copy.deepcopy(). > What is > different about the C implementation that requires the

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Gordon P. Hemsley added the comment: >> As discussed above, starting with msg309074, __deepcopy__() is being added >> to the Python implementation because it already exists in the C >> implementation. > > Python implementation shouldn't copy all implementation

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Serhiy Storchaka added the comment: > As discussed above, starting with msg309074, __deepcopy__() is being added to > the Python implementation because it already exists in the C implementation. Python implementation shouldn't copy all implementation details of

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Gordon P. Hemsley added the comment: As discussed above, starting with msg309074, __deepcopy__() is being added to the Python implementation because it already exists in the C implementation. And additional tests have in fact uncovered further discrepancies between

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Serhiy Storchaka added the comment: There is an existing test for copying. No new tests are needed. Just add a case for the copy() method in test_copy. Special __deepcopy__() method for Python implementation is not needed. copy.deepcopy() already works well.

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Gordon P. Hemsley added the comment: Given the discussion, I've gone ahead and created a new PR that synchronizes the three copy methods between implementations and deprecates Element.copy(). -- ___ Python tracker

[issue32424] Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element

Change by Gordon P. Hemsley : -- title: Rename copy() to __copy__() in xml.etree.ElementTree.Element Python implementation -> Synchronize copy methods between Python and C implementations of xml.etree.ElementTree.Element