[issue32528] Change base class for futures.CancelledError

miss-islington added the comment: New changeset ba07d4a0c30b4d817b4c31a052388a68cc17bc3b by Miss Islington (bot) in branch '3.9': bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474)

[issue32528] Change base class for futures.CancelledError

Change by miss-islington : -- pull_requests: +20747 pull_request: https://github.com/python/cpython/pull/21606 ___ Python tracker ___

[issue32528] Change base class for futures.CancelledError

miss-islington added the comment: New changeset 700cb6617545cdb8a9e16bb2e6efe90788a60d4d by Miss Islington (bot) in branch '3.8': bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474)

[issue32528] Change base class for futures.CancelledError

Change by miss-islington : -- pull_requests: +20621 pull_request: https://github.com/python/cpython/pull/21476 ___ Python tracker ___

[issue32528] Change base class for futures.CancelledError

Change by miss-islington : -- pull_requests: +20620 pull_request: https://github.com/python/cpython/pull/21475 ___ Python tracker ___

[issue32528] Change base class for futures.CancelledError

miss-islington added the comment: New changeset 2a5181829af394b82e8e8c917183c709ee72a2b7 by JustAnotherArchivist in branch 'master': bpo-32528: Document the change in inheritance of asyncio.CancelledError (GH-21474)

[issue32528] Change base class for futures.CancelledError

Change by JustAnotherArchivist : -- pull_requests: +20619 pull_request: https://github.com/python/cpython/pull/21474 ___ Python tracker ___

[issue32528] Change base class for futures.CancelledError

Guido van Rossum added the comment: Can you send a PR against what’s new 3.8? On Fri, Jul 10, 2020 at 20:14 JustAnotherArchivist wrote: > > JustAnotherArchivist added the comment: > > As another datapoint, this also broke some of my code on 3.8 because I was > using

[issue32528] Change base class for futures.CancelledError

JustAnotherArchivist added the comment: As another datapoint, this also broke some of my code on 3.8 because I was using `concurrent.futures.CancelledError` rather than `asyncio.CancelledError` to handle cancelled futures. And I'm certainly not the only one to have done this given that it's

[issue32528] Change base class for futures.CancelledError

Bruce Merry added the comment: FYI this has just bitten me after updating my OS to one that ships Python 3.8. It is code that was written with asyncio cancellation in mind and which expected CancelledError to be caught with "except Exception" (the exception block unwound incomplete

[issue32528] Change base class for futures.CancelledError

Yury Selivanov added the comment: Done. 爛 we don't regret this. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32528] Change base class for futures.CancelledError

Yury Selivanov added the comment: New changeset 431b540bf79f0982559b1b0e420b1b085f667bb7 by Yury Selivanov in branch 'master': bpo-32528: Make asyncio.CancelledError a BaseException. (GH-13528) https://github.com/python/cpython/commit/431b540bf79f0982559b1b0e420b1b085f667bb7 --

[issue32528] Change base class for futures.CancelledError

Change by Yury Selivanov : -- keywords: +patch pull_requests: +13442 stage: -> patch review ___ Python tracker ___ ___

[issue32528] Change base class for futures.CancelledError

Dima Tisnek added the comment: ping -- nosy: +Dima.Tisnek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32528] Change base class for futures.CancelledError

Change by Chris Jerdonek : -- nosy: +chris.jerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32528] Change base class for futures.CancelledError

Yury Selivanov added the comment: > Closing this issue as I, personally, don't see this happening and there's no > point in keeping it open. Actually, Andrew and I changed our opinion on this, so I'm re-opening the issue. After visiting three conferences this summer and talking to asyncio

[issue32528] Change base class for futures.CancelledError

Gustavo J. A. M. Carneiro added the comment: What a shame, I've seen this error many times as well. Surely making it BaseException will not break that much code?... -- nosy: +gustavo ___ Python tracker

[issue32528] Change base class for futures.CancelledError

Yury Selivanov added the comment: Closing this issue as I, personally, don't see this happening and there's no point in keeping it open. -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker

[issue32528] Change base class for futures.CancelledError

Joongi Kim added the comment: I strongly agree to have discretion of CancelledError and other general exceptions, though I don't have concrete ideas on good unobtrusive ways to achieve this. If I write my codes carefully I could control most of cancellation explicitly,

[issue32528] Change base class for futures.CancelledError

Change by Joongi Kim : -- nosy: +achimnol ___ Python tracker ___ ___ Python-bugs-list

[issue32528] Change base class for futures.CancelledError

Andrew Svetlov added the comment: Honestly I have no strong opinion. Correct code should not be affected, if somebody want to handle task cancellation explicitly -- he already have `except CancelledError` in his code. What are use cases for intentional catching

[issue32528] Change base class for futures.CancelledError

Andrew Svetlov added the comment: Inheritance from Exception is very annoying, I saw issues with unexpected suppressing CancelledError many times. Even experienced people constantly forget to add a separate `except asyncio.CancelledError` clause everywhere. But

[issue32528] Change base class for futures.CancelledError

Марк Коренберг added the comment: @gvanrossum More real code: async def (): while True: try: result = await download() handle_result(result) except Exception as e: log.warning('Fail..%r', e) await

[issue32528] Change base class for futures.CancelledError

Guido van Rossum added the comment: I agree with Yury, this feels too risky to consider. The "except Exception: " code is at fault. -- ___ Python tracker

[issue32528] Change base class for futures.CancelledError

Yury Selivanov added the comment: While I understand the reasons for the proposed change, I'd still be -1 for it. Solely on the basis of "we don't know how much this change will break, but it will surely break something in very subtle ways". Another problem is that

[issue32528] Change base class for futures.CancelledError

Марк Коренберг added the comment: Will you accept PR if I fix that ? I think we may merge that in Python 3.8 Who can also judge us? @asvetlov, what do you think about my idea ? -- ___ Python tracker

[issue32528] Change base class for futures.CancelledError

Yury Selivanov added the comment: This is a backwards incompatible change. IMO it's too late to change this. -- ___ Python tracker

[issue32528] Change base class for futures.CancelledError

Change by Марк Коренберг : -- components: +Library (Lib) ___ Python tracker ___ ___

[issue32528] Change base class for futures.CancelledError

Change by Марк Коренберг : -- type: -> enhancement ___ Python tracker ___ ___

[issue32528] Change base class for futures.CancelledError

New submission from Марк Коренберг : I have discoverd one very ugly pattern connected with asyncio. Many times I see code like this: try: await something() except Exception: log.error('Opertaion failed -- will retry later.') Seems, everything is fine, but