[issue32563] -Werror=declaration-after-statement expat build failure on Python 3.5

Nick Coghlan added the comment: Tidying up old git branches, and I noticed this was still open even though Larry had long ago merged the PR. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5

[issue32563] -Werror=declaration-after-statement expat build failure on Python 3.5

Larry Hastings added the comment: New changeset 57fa0ab8911a70d91e5b60b8dc91f1085442a9e7 by larryhastings (Nick Coghlan) in branch '3.5': [3.5] bpo-32563: Get expat to compile under C89 (#5201)

[issue32563] -Werror=declaration-after-statement expat build failure on Python 3.5

Nick Coghlan added the comment: I couldn't persuade git to pull the upstream patch in directly, so I just made the same change downstream: https://github.com/python/cpython/pull/5201 -- ___ Python tracker

[issue32563] -Werror=declaration-after-statement expat build failure on Python 3.5

Change by Nick Coghlan : -- keywords: +patch pull_requests: +5055 stage: needs patch -> patch review ___ Python tracker ___

[issue32563] -Werror=declaration-after-statement expat build failure on Python 3.5

STINNER Victor added the comment: Hum, I backported a fix to 3.4 but I forgot Python 3.5. My fix for Python 3.4 is made of multiple bugfixes: 8b11e8de7aedacfbbcc8c780f3c4097396f1d1a3 For Python 3.5, you want at least this change I think:

[issue32563] -Werror=declaration-after-statement expat build failure on Python 3.5

Nick Coghlan added the comment: Details of the compilation failure: ``` building 'pyexpat' extension gcc -pthread -fPIC -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Werror=declaration-after-statement -DHAVE_EXPAT_CONFIG_H=1

[issue32563] -Werror=declaration-after-statement expat build failure on Python 3.5

New submission from Nick Coghlan : A fresh Python 3.5 checkout failed to build the embedded expat XML library for me, due to the configure check that adds "-Werror=declaration-after-statement" to the compiler flags. I'm guessing this was introduced via the expat code