[issue32660] Solaris should support constants like termios' FIONREAD

Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32660] Solaris should support constants like termios' FIONREAD

Jesús Cea Avión added the comment: New changeset f0a95f27c043e847a23940534fdfc53e1b3e31a1 by jcea in branch 'master': bpo-32660: Solaris should support constants like termios' FIONREAD (#5328) https://github.com/python/cpython/commit/f0a95f27c043e847a23940534fdfc53e1b3e31a1

[issue32660] Solaris should support constants like termios' FIONREAD

Change by Jesús Cea Avión : -- keywords: +patch pull_requests: +5173 stage: needs patch -> patch review ___ Python tracker ___

[issue32660] Solaris should support constants like termios' FIONREAD

Jesús Cea Avión added the comment: With this change, a SmarOS native zone exports 206 symbols in Python termios. Before it export 201. By comparison, a Linux Ubuntu 16.04 Python provides 244 symbols. Some references for the future:

[issue32660] Solaris should support constants like termios' FIONREAD

Jesús Cea Avión added the comment: After doing this change, I see FIVE new symbols in Python's termios: """ FIONREAD, FIONCLEX, FIOCLEX, FIOASYNC, FIONBIO. """ Good enough for now and me. -- ___ Python tracker

[issue32660] Solaris should support constants like termios' FIONREAD

Jesús Cea Avión added the comment: Solaris has two personalities: System V and BSD. This is not usually an issue but sometimes some constants have a different value in a mode or the other. By default, when including Solaris is in System V mode. We can force BSD mode defining

[issue32660] Solaris should support constants like termios' FIONREAD

New submission from Jesús Cea Avión : Solaris supports termios constants like FIONREAD with an appropiate "#include" in the C code. The main issue is that some names conflicts between System V and BSD personalities. I could evaluate the situation and do a patch proposal for