[issue32779] urljoining an empty query string doesn't clear query string

Paul Fisher added the comment: Reading more into this, from section 5.2,1: > A component is undefined if its associated delimiter does not appear in the > URI reference So you could say that since there is a '?', the query component is *defined*, but *empty*. This would mean that assigning

[issue32779] urljoining an empty query string doesn't clear query string

Irit Katriel added the comment: Sorry, urlparse returns '' rather than None when there is no query. So we indeed need to check something like if '?' not in url: or what's in Paul's patch. However, my main point was to question whether fixing this is actually in contradiction with the

[issue32779] urljoining an empty query string doesn't clear query string

Irit Katriel added the comment: The relevant part in the RFC pseudo code is if defined(R.query) then T.query = R.query; else T.query = Base.query; endif; which is implemented in urljoin as: if not

[issue32779] urljoining an empty query string doesn't clear query string

Paul Fisher added the comment: In this case, the RFC is mismatched from the actual behaviour of browsers (as described and codified by WhatWG). It was surprising to me that urljoin() didn't do what I percieved as "the right thing" (and I expect other users would too). I

[issue32779] urljoining an empty query string doesn't clear query string

Andrew Svetlov added the comment: Python follows not WhatWG but RFC. https://tools.ietf.org/html/rfc3986#section-5.2.2 is proper definition for url joining algorithm. -- nosy: +asvetlov ___ Python tracker

[issue32779] urljoining an empty query string doesn't clear query string

Change by Roundup Robot : -- keywords: +patch pull_requests: +5446 stage: -> patch review ___ Python tracker ___

[issue32779] urljoining an empty query string doesn't clear query string

Paul Fisher added the comment: I'm working on a patch for this and can have one up in the next week or so, once I get the CLA signed and other boxes ticked. I'm new to the Github process but hopefully it will be a good start for the discussion. --

[issue32779] urljoining an empty query string doesn't clear query string

Change by Terry J. Reedy : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list

[issue32779] urljoining an empty query string doesn't clear query string

New submission from Paul Fisher : urljoining with '?' will not clear a query string: ACTUAL: >>> import urllib.parse >>> urllib.parse.urljoin('http://a/b/c?d=e', '?') 'http://a/b/c?d=e' EXPECTED: 'http://a/b/c' (optionally, with a ? at the end) WhatWG's URL standard