[issue33057] logging.Manager.logRecordFactory is never used

Vinay Sajip added the comment: I'm closing this, please reopen if you have more information which might change my view. -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33057] logging.Manager.logRecordFactory is never used

Vinay Sajip added the comment: > However, it seems that someone already thought about it before and started > implementing this mechanism That someone was me. I decided that a single module-level factory was good enough but failed to delete the things you noticed.

[issue33057] logging.Manager.logRecordFactory is never used

Ben Feinstein added the comment: General loggers are used in the standard way (message, args, etc), but data loggers are used for different types of data. Instead of message, they receive the experiment results (dict/list/np.array/binary data) and their `formatMessage()`

[issue33057] logging.Manager.logRecordFactory is never used

Vinay Sajip added the comment: > I have two types of loggers, one for experiment results ("data") and another > for general information In what way is the behaviour of the two types of logger different? I'm concerned that this might be an XY problem ... --

[issue33057] logging.Manager.logRecordFactory is never used

Ben Feinstein added the comment: I use the logging module to log records of lab experiments. I have two types of loggers, one for experiment results ("data") and another for general information. I think that having a different managers for data loggers is the easiest way

[issue33057] logging.Manager.logRecordFactory is never used

Vinay Sajip added the comment: The logRecordFactory attribute was added but never used and is part of an internal API (the Manager isn't documented, on purpose). Why do you need a manager-specific factory? -- ___ Python

[issue33057] logging.Manager.logRecordFactory is never used

Ben Feinstein added the comment: Here is a code that demonstrate the bug: ```python import logging class LogRecordTypeFilter(logging.Filter): def __init__(self, cls): self.cls = cls def filter(self, record): t = type(record) if t is not

[issue33057] logging.Manager.logRecordFactory is never used

Change by Ben Feinstein : Removed file: https://bugs.python.org/file47478/issue_logRecordFactory.py ___ Python tracker ___

[issue33057] logging.Manager.logRecordFactory is never used

Change by Ben Feinstein : -- keywords: +patch pull_requests: +5848 stage: -> patch review ___ Python tracker ___

[issue33057] logging.Manager.logRecordFactory is never used

New submission from Ben Feinstein : In logging.Manager, the logRecordFactory attribute is never used. One would expect that makeRecord() (in logging.Logger) would generate a record using its manager's logRecordFactory, or fallback to the global _logRecordFactory (if