[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: I clarified the docs to mention that the inheritable flag is heeded when close_fds=False in https://github.com/python/cpython/pull/6240/files -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: I assumed simon meant "close_fds=False" when he wrote open_fds = True. Regardless, supplying any pass_fds forces close_fds=True behavior. File descriptors listed in pass_fds are explicitly set inheritable from within the child process

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-25 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +5976 stage: -> patch review ___ Python tracker ___

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-25 Thread Martin Panter
Martin Panter added the comment: There is no “open_fds” parameter as far as I know. I presume you meant heritable descriptors are still closed with close_fds=True (not open_fds=False). Are you sure about the second part? In my experiments on Linux, unless I use

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-15 Thread Ned Deily
Change by Ned Deily : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list

[issue33079] subprocess: document the interaction between subprocess.Popen and os.set_inheritable

2018-03-15 Thread Simon Lipp
New submission from Simon Lipp : >From current `os` documentation: > A file descriptor has an “inheritable” flag which indicates if the file > descriptor can be inherited by child processes from current `subprocess` documentation: > If close_fds is true, all file