[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Serhiy Storchaka added the comment: New changeset 903f189b6e528cbe9500014c6f990c6511b38918 by Serhiy Storchaka in branch '2.7': bpo-33096: Removed unintentionally backported from Python 3 Tkinter files. (GH-6724)

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Change by Serhiy Storchaka : -- pull_requests: +6417 ___ Python tracker ___ ___

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Serhiy Storchaka added the comment: New changeset e80a232f2cfdab584133d9779c83885c5f9f1ba6 by Serhiy Storchaka in branch '2.7': [2.7] bpo-33096: Fix ttk.Treeview.insert. (GH-6228) (GH-6326)

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Change by Serhiy Storchaka : -- pull_requests: +6040 ___ Python tracker ___ ___

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

miss-islington added the comment: New changeset 45116d393f713bbe918f16b33a0bba28b15bc96b by Miss Islington (bot) in branch '3.6': bpo-33096: Fix ttk.Treeview.insert. (GH-6228)

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

miss-islington added the comment: New changeset a7b1b847f665aafc22557917cea32ec34c9b4418 by Miss Islington (bot) in branch '3.7': bpo-33096: Fix ttk.Treeview.insert. (GH-6228)

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Change by miss-islington : -- pull_requests: +5980 ___ Python tracker ___

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Change by miss-islington : -- pull_requests: +5979 ___ Python tracker ___

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Serhiy Storchaka added the comment: New changeset 3ab44c0783eebdff687014f7d14d5dec59b6bd39 by Serhiy Storchaka (Garvit Khatri) in branch 'master': bpo-33096: Fix ttk.Treeview.insert. (GH-6228)

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Change by Garvit Khatri : -- keywords: +patch pull_requests: +5967 stage: needs patch -> patch review ___ Python tracker ___

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Serhiy Storchaka added the comment: Yes, this is expected. -- ___ Python tracker ___

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Garvit Khatri added the comment: I made the changes on my machine and I\in my testing, it breaks on an empty string with an error saying "Item already exists". If this is expected I would like to submit a patch with tests for the same. -- nosy: +garvitdelhi

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Serhiy Storchaka added the comment: I have tested -- omitting the option and passing an empty string are treated different in Tk. Passing a duplicate iid is error. Thus the fix should be just `iid is not None`. But needed tests. -- keywords: +easy stage:

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Terry J. Reedy added the comment: This was initially reported in pydev thread "ttk.Treeview.insert() does not allow to insert item with iid=0" on 2018/3/16. Igor, you should have mentioned on the thread that you had opened a tracker issue in response. It was only

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka versions: +Python 2.7, Python 3.7, Python 3.8 ___ Python tracker

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

New submission from Igor Yakovchenko : ttk.Treeview.insert(... iid=None, ...) method has a check: if iid: res = self.tk.call(self._w, "insert", parent, index, "-id", iid, *opts) else: res = self.tk.call(self._w,